SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
Ruby

Ruby static code analysis

Unique rules to find Bugs, Security Hotspots, and Code Smells in your RUBY code

  • All rules 75
  • Bug17
  • Security Hotspot2
  • Code Smell56
 
Tags
    Impact
      Clean code attribute
        1. Before destroy callbacks should use proper halt mechanism

           Bug
        2. Rails applications should define a root route with proper controller#action syntax

           Bug
        3. Non-mutating sort methods should have their return values used

           Bug
        4. "return" statements should not be used in blocks

           Bug
        5. Rails API controllers using "respond_to" should include "ActionController::MimeResponds"

           Bug
        6. Environment variables should be validated or have default values

           Bug
        7. Regular expressions should not be passed to "String#include?"

           Bug
        8. Symbol keys containing hyphens should be quoted

           Bug
        9. Column names should not use SQL reserved words

           Bug
        10. ActiveRecord models should override "as_json" instead of "to_json" for custom JSON serialization

           Bug
        11. All branches in a conditional structure should not have exactly the same implementation

           Bug
        12. Non-existent operators like "=+" should not be used

           Bug
        13. Related "if/elsif" statements and "when" in a "case" should not have the same condition

           Bug
        14. Identical expressions should not be used on both sides of a binary operator

           Bug
        15. All code should be reachable

           Bug
        16. Variables should not be self-assigned

           Bug
        17. Useless "if true ..." and "if false ..." blocks should be removed

           Bug

        Before destroy callbacks should use proper halt mechanism

        intentionality - logical
        reliability
        Bug
        • rails
        • callbacks
        • data-integrity

        This is an issue when a before_destroy callback adds validation errors but fails to properly halt the destruction process.

        Why is this an issue?

        How can I fix it?

        More Info

        In Rails applications, before_destroy callbacks are commonly used to validate whether a record can be safely deleted. However, simply adding errors to the model does not automatically prevent destruction.

        In Rails versions prior to 5.0, returning false from a callback would halt the callback chain and prevent the destruction. However, this behavior changed in Rails 5.0 for consistency with other callback types.

        Starting with Rails 5.0, callbacks must explicitly use throw :abort to halt execution. The return false approach silently fails, allowing records to be destroyed despite validation errors.

        When callbacks add errors but fail to halt execution, the destruction proceeds normally. This creates a misleading situation where the model appears to have validation errors, but the record is still deleted from the database. This can lead to data integrity issues, orphaned records, and broken business logic.

        What is the potential impact?

        Records may be destroyed despite validation failures, leading to data integrity issues and broken business logic. Users may receive error messages but still see their data deleted, creating confusion and potential data loss.

          Available In:
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use