SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
Ruby

Ruby static code analysis

Unique rules to find Bugs, Security Hotspots, and Code Smells in your RUBY code

  • All rules 75
  • Bug17
  • Security Hotspot2
  • Code Smell56
Filtered: 19 rules found
convention
    Impact
      Clean code attribute
        1. Modules should use "extend self" instead of "module_function"

           Code Smell
        2. Array and hash literals should be used instead of constructors when no parameters are needed

           Code Smell
        3. Logical operators "and" and "or" should be replaced with "&&" and "||"

           Code Smell
        4. Private methods should be declared at the end of Ruby classes

           Code Smell
        5. Predicate methods should not use redundant "is_" prefix

           Code Smell
        6. Controllers should inherit from appropriate base classes

           Code Smell
        7. Rails model callback methods should be private

           Code Smell
        8. Rails collections should use "ids" instead of "pluck(:id)" for primary keys

           Code Smell
        9. Rails queries should use "find_by" instead of "where.take" for single record retrieval

           Code Smell
        10. Safe navigation operator should be preferred over ActiveSupport's "try!"

           Code Smell
        11. Use "require_relative" instead of "require" for loading local files

           Code Smell
        12. Require statements should be placed at the top of files

           Code Smell
        13. Track lack of copyright and license headers

           Code Smell
        14. Statements should be on separate lines

           Code Smell
        15. Function and block parameter names should comply with a naming convention

           Code Smell
        16. Tabulation characters should not be used

           Code Smell
        17. Lines should not be too long

           Code Smell
        18. Class names should comply with a naming convention

           Code Smell
        19. Method names should comply with a naming convention

           Code Smell

        Logical operators "and" and "or" should be replaced with "&&" and "||"

        consistency - conventional
        reliability
        maintainability
        Code Smell
        • convention
        • style

        This rule raises an issue when the logical operators and and or are used instead of && and ||.

        Why is this an issue?

        How can I fix it?

        More Info

        Ruby has two sets of logical operators: &&/|| and and/or. While they perform similar operations, they have very different precedence levels that can lead to unexpected behavior.

        The and and or operators have extremely low precedence - lower than assignment operators like =. This means they are evaluated last in most expressions, which often produces surprising results.

        Consider this example:

        result = condition1 and condition2
        

        Due to precedence, this is actually parsed as:

        (result = condition1) and condition2
        

        This assigns condition1 to result, then evaluates condition2 separately. The and operation doesn’t affect the assignment at all.

        In contrast, && and || have higher precedence than assignment operators, so they work as most developers expect:

        result = condition1 && condition2
        

        This correctly assigns the result of the logical operation to the variable.

        The precedence issue becomes even more problematic in complex expressions with multiple operators, where the evaluation order can be completely different from what appears obvious when reading the code.

        What is the potential impact?

        Using and and or can cause logic errors where variables receive unexpected values due to operator precedence. This can lead to:

        • Incorrect conditional logic that appears to work in simple cases but fails in complex expressions
        • Variables being assigned partial results instead of the full logical operation
        • Difficult-to-debug issues where the code looks correct but behaves unexpectedly
        • Reduced code readability as other developers may misunderstand the actual execution order
          Available In:
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use