SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
RPG

RPG static code analysis

Unique rules to find Bugs, Security Hotspots, and Code Smells in your RPG code

  • All rules 58
  • Vulnerability1
  • Bug7
  • Security Hotspot1
  • Code Smell49
Filtered: 2 rules found
pitfall
    Impact
      Clean code attribute
        1. Variables used in only one subprocedure should not be global

           Code Smell
        2. Related "IF/ELSEIF" statements and "WHEN" clauses in a "SELECT" should not have the same condition

           Bug

        Variables used in only one subprocedure should not be global

        adaptability - modular
        maintainability
        Code Smell
        • pitfall

        Why is this an issue?

        Global variables that are only used by a single subprocedure should be declared in that subprocedure, thus limiting both their scope and other procedures' ability to modify the variable unexpectedly.

        If the variable has been declared in the global scope to preserve its value between calls, add the STATIC keyword to the new local declaration. It will be added to the global heap and retained until the program ends, but only accessible by the subprocedure in which it was declared.

        Noncompliant code example

             D SUBPROC1        PR
             D  Parm1                         5  0 Const
        
             D X               S              5  0    // Noncompliant; only used in one subproc
        
              /Free
               SUBPROC1(1234);
               *inlr = *on;
               return;
               /End-free
        
             P SUBPROC1        B
             D SUBPROC1        PI
             D  Parm1                         5  0 Const
              /Free
               X = Parm1 + 1;                        // X is only used here
               DSPLY(E) X;
              /End-Free
             P                 E
        

        Compliant solution

             D SUBPROC1        PR
             D  Parm1                         5  0 Const
        
              /Free
               SUBPROC1(1234);
               *inlr = *on;
               return;
               /End-free
        
             P SUBPROC1        B
             D SUBPROC1        PI
             D  Parm1                         5  0 Const
             D X               S              5  0
              /Free
               X = Parm1 + 1;
               DSPLY(E) X;
              /End-Free
             P                 E
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Enterprise
          Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use