A loop with at most one iteration is equivalent to the use of an if
statement to conditionally execute one piece of code. No developer
expects to find such a use of a loop statement. If the initial intention of the author was really to conditionally execute one piece of code, an
if
statement should be used instead.
At worst that was not the initial intention of the author and so the body of the loop should be fixed to use the nested return
,
break
or throw
statements in a more appropriate way.
Noncompliant code example
for ($i = 0; $i < 10; $i++) { // Noncompliant
echo "i is $i";
break;
}
...
for ($i = 0; $i < 10; $i++) { // Noncompliant
if ($i == $x) {
break;
} else {
echo "i is $i";
return;
}
}
Compliant solution
for ($i = 0; $i < 10; $i++) {
echo "i is $i";
}
...
for ($i = 0; $i < 10; $i++) {
if ($i == $x) {
break;
} else {
echo "i is $i";
}
}