Declaring a variable only to immediately return or throw it is considered a bad practice because it adds unnecessary complexity to the code. This
practice can make the code harder to read and understand, as it introduces an extra step that doesn’t add any value. Instead of declaring a variable
and then immediately returning or throwing it, it is generally better to return or throw the value directly. This makes the code cleaner, simpler, and
easier to understand.
Noncompliant code example
function computeDurationInMilliseconds() {
$duration = ((($hours * 60) + $minutes) * 60 + $seconds ) * 1000 ;
return $duration;
}
Compliant solution
function computeDurationInMilliseconds() {
return ((($hours * 60) + $minutes) * 60 + $seconds ) * 1000;
}
