SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
Java

Java static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your JAVA code

  • All rules 733
  • Vulnerability60
  • Bug175
  • Security Hotspot40
  • Code Smell458

  • Quick Fix 65
Filtered: 49 rules found
spring
    Impact
      Clean code attribute
        1. Methods annotated with "@BeforeTransaction" or "@AfterTransaction" must respect the contract

           Code Smell
        2. Methods returning "Page" or "Slice" must take "Pageable" as an input parameter

           Code Smell
        3. @EventListener methods should have one parameter at most

           Bug
        4. "@Scheduled" annotation should only be applied to no-arg methods

           Bug
        5. @InitBinder methods should have void return type

           Code Smell
        6. "@Cache*" annotations should only be applied on concrete classes

           Code Smell
        7. @Cacheable and @CachePut should not be combined

           Code Smell
        8. Injecting data into static fields is not supported by Spring

           Code Smell
        9. Use appropriate @DirtiesContext modes

           Code Smell
        10. Set appropriate Status Codes on HTTP responses

           Bug
        11. Beans in "@Configuration" class should have different names

           Bug
        12. SpEL expression should have a valid syntax

           Bug
        13. "@PathVariable" annotation should be present if a path variable is used

           Bug
        14. "@Bean" methods for Singleton should not be invoked in "@Configuration" when proxyBeanMethods is false

           Bug
        15. Superfluous "@ResponseBody" annotations should be removed

           Code Smell
        16. "@Controller" should be replaced with "@RestController"

           Code Smell
        17. Non-singleton Spring beans should not be injected into singleton beans

           Code Smell
        18. "@Qualifier" should not be used on "@Bean" methods

           Bug
        19. Bean names should adhere to the naming conventions

           Code Smell
        20. "@Autowired" should be used when multiple constructors are provided

           Code Smell
        21. "@Autowired" should only be used on a single constructor

           Bug
        22. Use of the "@Async" annotation on methods declared within a "@Configuration" class in Spring Boot

           Bug
        23. Nullable injected fields and parameters should provide a default value

           Bug
        24. "@Value" annotation should inject property or SpEL expression

           Code Smell
        25. Spring's ModelAndViewAssert assertions should be used instead of other assertions

           Code Smell
        26. A new session should be created during user authentication

           Vulnerability
        27. Allowing user enumeration is security-sensitive

           Security Hotspot
        28. OpenSAML2 should be configured to prevent authentication bypass

           Vulnerability
        29. Passwords should not be stored in plaintext or with a fast hashing algorithm

           Vulnerability
        30. Having a permissive Cross-Origin Resource Sharing policy is security-sensitive

           Security Hotspot
        31. Persistent entities should not be used as arguments of "@RequestMapping" methods

           Vulnerability
        32. Spring beans should be considered by "@ComponentScan"

           Code Smell
        33. "@SpringBootApplication" and "@ComponentScan" should not be used in the default package

           Bug
        34. "HttpSecurity" URL patterns should be correctly ordered

           Vulnerability
        35. Delivering code in production with debug features activated is security-sensitive

           Security Hotspot
        36. Disabling CSRF protections is security-sensitive

           Security Hotspot
        37. Composed "@RequestMapping" variants should be preferred

           Code Smell
        38. Spring components should use constructor injection

           Code Smell
        39. "@Controller" classes that use "@SessionAttributes" must call "setComplete" on their "SessionStatus" objects

           Bug
        40. Allowing both safe and unsafe HTTP methods is security-sensitive

           Security Hotspot
        41. "@RequestMapping" methods should not be "private"

           Code Smell
        42. Spring "@Controller" classes should not use "@Scope"

           Bug
        43. Members of Spring components should be injected

           Code Smell
        44. Constructor injection should be used instead of field injection

           Bug
        45. Factory method injection should be used in "@Configuration" classes

           Code Smell
        46. Methods with Spring proxying annotations should be public

           Bug
        47. Methods should not call same-class methods with incompatible "@Transactional" values

           Bug
        48. Creating cookies without the "secure" flag is security-sensitive

           Security Hotspot
        49. Formatting SQL queries is security-sensitive

           Security Hotspot

        "@RequestMapping" methods should not be "private"

        intentionality - clear
        maintainability
        Code Smell
        • spring

        Why is this an issue?

        More Info

        A method with a @RequestMapping annotation part of a class annotated with @Controller (directly or indirectly through a meta annotation - @RestController from Spring Boot is a good example) will be called to handle matching web requests. That will happen even if the method is private, because Spring invokes such methods via reflection, without checking visibility.

        So marking a sensitive method private may seem like a good way to control how such code is called. Unfortunately, not all Spring frameworks ignore visibility in this way. For instance, if you’ve tried to control web access to your sensitive, private, @RequestMapping method by marking it @Secured …​ it will still be called, whether or not the user is authorized to access it. That’s because AOP proxies are not applied to private methods.

        In addition to @RequestMapping, this rule also considers the annotations introduced in Spring Framework 4.3: @GetMapping, @PostMapping, @PutMapping, @DeleteMapping, @PatchMapping.

        Noncompliant code example

        @RequestMapping("/greet", method = GET)
        private String greet(String greetee) {  // Noncompliant
        

        Compliant solution

        @RequestMapping("/greet", method = GET)
        public String greet(String greetee) {
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube Community BuildAnalyze code in your
          on-premise CI
          Available Since
          9.1
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use