SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
Java

Java static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your JAVA code

  • All rules 733
  • Vulnerability60
  • Bug175
  • Security Hotspot40
  • Code Smell458

  • Quick Fix 65
Filtered: 5 rules found
mockito
    Impact
      Clean code attribute
        1. Mockito argument matchers should be used on all parameters

           Bug
        2. Call to Mockito method "verify", "when" or "given" should be simplified

           Code Smell
        3. Annotated Mockito objects should be initialized

           Bug
        4. Mocking all non-private methods of a class should be avoided

           Code Smell
        5. Assertions should be complete

           Code Smell

        Call to Mockito method "verify", "when" or "given" should be simplified

        intentionality - clear
        maintainability
        Code Smell
        • tests
        • mockito
        • clumsy

        Why is this an issue?

        More Info

        Mockito provides argument matchers for flexibly stubbing or verifying method calls.

        Mockito.verify(), Mockito.when(), Stubber.when() and BDDMockito.given() each have overloads with and without argument matchers.

        However, the default matching behavior (i.e. without argument matchers) uses equals(). If only the matcher org.mockito.ArgumentMatchers.eq() is used, the call is equivalent to the call without matchers, i.e. the eq() is not necessary and can be omitted. The resulting code is shorter and easier to read.

        Noncompliant code example

        @Test
        public void myTest() {
          given(foo.bar(eq(v1), eq(v2), eq(v3))).willReturn(null);   // Noncompliant
          when(foo.baz(eq(v4), eq(v5))).thenReturn("foo");   // Noncompliant
          doThrow(new RuntimeException()).when(foo).quux(eq(42));    // Noncompliant
          verify(foo).bar(eq(v1), eq(v2), eq(v3));   // Noncompliant
        }
        

        Compliant solution

        @Test
        public void myTest() {
          given(foo.bar(v1, v2, v3)).willReturn(null);
          when(foo.baz(v4, v5)).thenReturn("foo");
          doThrow(new RuntimeException()).when(foo).quux(42);
          verify(foo).bar(v1, v2, v3);
        }
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube Community BuildAnalyze code in your
          on-premise CI
          Available Since
          9.1
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use