SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
Java

Java static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your JAVA code

  • All rules 733
  • Vulnerability60
  • Bug175
  • Security Hotspot40
  • Code Smell458

  • Quick Fix 65
Filtered: 5 rules found
mockito
    Impact
      Clean code attribute
        1. Mockito argument matchers should be used on all parameters

           Bug
        2. Call to Mockito method "verify", "when" or "given" should be simplified

           Code Smell
        3. Annotated Mockito objects should be initialized

           Bug
        4. Mocking all non-private methods of a class should be avoided

           Code Smell
        5. Assertions should be complete

           Code Smell

        Mocking all non-private methods of a class should be avoided

        adaptability - focused
        maintainability
        Code Smell
        • tests
        • mockito

        Why is this an issue?

        If you end up mocking every non-private method of a class in order to write tests, it is a strong sign that your test became too complex, or that you misunderstood the way you are supposed to use the mocking mechanism.

        You should either refactor the test code into multiple units, or consider using the class itself, by either directly instantiating it, or creating a new one inheriting from it, with the expected behavior.

        This rule reports an issue when every member of a given class are mocked.

        Noncompliant code example

        @Test
        void test_requiring_MyClass() {
          MyClass myClassMock = mock(MyClass.class); // Noncompliant
          when(myClassMock.f()).thenReturn(1);
          when(myClassMock.g()).thenReturn(2);
          //...
        }
        
        abstract class MyClass {
          abstract int f();
          abstract int g();
        }
        

        Compliant solution

        @Test
        void test_requiring_MyClass() {
          MyClass myClass = new MyClassForTest();
          //...
        }
        
        class MyClassForTest extends MyClass {
        
          @Override
          int f() {
            return 1;
          }
        
          @Override
          int g() {
            return 2;
          }
        }
        

        or

        @Test
        void test_requiring_f() {
          MyClass myClassMock = mock(MyClass.class);
          when(myClassMock.f()).thenReturn(1);
          //...
        }
        
        @Test
        void test_requiring_g() {
          MyClass myClassMock = mock(MyClass.class);
          when(myClassMock.g()).thenReturn(2);
          //...
        }
        
        abstract class MyClass {
          abstract int f();
          abstract int g();
        }
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube Community BuildAnalyze code in your
          on-premise CI
          Available Since
          9.1
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use