SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
Java

Java static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your JAVA code

  • All rules 733
  • Vulnerability60
  • Bug175
  • Security Hotspot40
  • Code Smell458

  • Quick Fix 65
Filtered: 2 rules found
jee
    Impact
      Clean code attribute
        1. Constructor injection should be used instead of field injection

           Bug
        2. JEE applications should not "getClassLoader"

           Bug

        Constructor injection should be used instead of field injection

        intentionality - complete
        reliability
        Bug
        • spring
        • design
        • jee
        • pitfall

        Why is this an issue?

        Field injection seems like a tidy way to get your classes what they need to do their jobs, but it’s really a NullPointerException waiting to happen unless all your class constructors are private. That’s because any class instances that are constructed by callers, rather than instantiated by a Dependency Injection framework compliant with the JSR-330 (Spring, Guice, …​), won’t have the ability to perform the field injection.

        Instead @Inject should be moved to the constructor and the fields required as constructor parameters.

        This rule raises an issue when classes with non-private constructors (including the default constructor) use field injection.

        Noncompliant code example

        class MyComponent {  // Anyone can call the default constructor
        
          @Inject MyCollaborator collaborator;  // Noncompliant
        
          public void myBusinessMethod() {
            collaborator.doSomething();  // this will fail in classes new-ed by a caller
          }
        }
        

        Compliant solution

        class MyComponent {
        
          private final MyCollaborator collaborator;
        
          @Inject
          public MyComponent(MyCollaborator collaborator) {
            Assert.notNull(collaborator, "MyCollaborator must not be null!");
            this.collaborator = collaborator;
          }
        
          public void myBusinessMethod() {
            collaborator.doSomething();
          }
        }
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube Community BuildAnalyze code in your
          on-premise CI
          Available Since
          9.1
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use