SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
Java

Java static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your JAVA code

  • All rules 733
  • Vulnerability60
  • Bug175
  • Security Hotspot40
  • Code Smell458

  • Quick Fix 65
Filtered: 17 rules found
design
    Impact
      Clean code attribute
        1. Circular dependencies between classes across packages should be resolved

           Code Smell
        2. Circular dependencies between classes in the same package should be resolved

           Code Smell
        3. The Singleton design pattern should be used with care

           Code Smell
        4. Methods should not perform too many tasks (aka Brain method)

           Code Smell
        5. Classes should not depend on an excessive number of classes (aka Monster Class)

           Code Smell
        6. Constructors of an "abstract" class should not be declared "public"

           Code Smell
        7. Tests should use fixed data instead of randomized data

           Code Smell
        8. Tests should be stable

           Code Smell
        9. Spring components should use constructor injection

           Code Smell
        10. Constructor injection should be used instead of field injection

           Bug
        11. "ThreadGroup" should not be used

           Code Smell
        12. Classes without "public" constructors should be "final"

           Code Smell
        13. Public methods should not contain selector arguments

           Code Smell
        14. Double-checked locking should not be used

           Bug
        15. Two branches in a conditional structure should not have exactly the same implementation

           Code Smell
        16. String literals should not be duplicated

           Code Smell
        17. Utility classes should not have public constructors

           Code Smell

        Two branches in a conditional structure should not have exactly the same implementation

        adaptability - distinct
        maintainability
        Code Smell
        • design
        • suspicious

        Why is this an issue?

        More Info

        When the same code is duplicated in two or more separate branches of a conditional, it can make the code harder to understand, maintain, and can potentially introduce bugs if one instance of the code is changed but others are not.

        Having two cases in a switch statement or two branches in an if chain with the same implementation is at best duplicate code, and at worst a coding error.

        if (a >= 0 && a < 10) {
          doFirstThing();
          doTheThing();
        }
        else if (a >= 10 && a < 20) {
          doTheOtherThing();
        }
        else if (a >= 20 && a < 50) {
          doFirstThing();
          doTheThing();  // Noncompliant; duplicates first condition
        }
        else {
          doTheRest();
        }
        
        switch (i) {
          case 1:
            doFirstThing();
            doSomething();
            break;
          case 2:
            doSomethingDifferent();
            break;
          case 3:  // Noncompliant; duplicates case 1's implementation
            doFirstThing();
            doSomething();
            break;
          default:
            doTheRest();
        }
        

        If the same logic is truly needed for both instances, then:

        • in an if chain they should be combined
        if ((a >= 0 && a < 10) || (a >= 20 && a < 50)) { // Compliant
          doFirstThing();
          doTheThing();
        }
        else if (a >= 10 && a < 20) {
          doTheOtherThing();
        }
        else {
          doTheRest();
        }
        
        • for a switch, one should fall through to the other
        switch (i) {
          case 1:
          case 3: // Compliant
            doFirstThing();
            doSomething();
            break;
          case 2:
            doSomethingDifferent();
            break;
          default:
            doTheRest();
        }
        

        When all blocks are identical, either this rule will trigger if there is no default clause or rule S3923 will raise if there is a default clause.

        Exceptions

        Unless all blocks are identical, blocks in an if chain that contain a single line of code are ignored. The same applies to blocks in a switch statement that contains a single line of code with or without a following break.

        if (a == 1) {
          doSomething();  // Compliant, usually this is done on purpose to increase the readability
        } else if (a == 2) {
          doSomethingElse();
        } else {
          doSomething();
        }
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube Community BuildAnalyze code in your
          on-premise CI
          Available Since
          9.1
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use