When testing exception via @Test annotation, having additional assertions inside that test method can be problematic because any code
after the raised exception will not be executed. It will prevent you to test the state of the program after the raised exception and, at worst, make
you misleadingly think that it is executed.
You should consider moving any assertions into a separate test method where possible, or using org.junit.Assert.assertThrows instead.
Alternatively, you could use try-catch idiom for JUnit
version < 4.13 or if your project does not support lambdas.
Noncompliant code example
@Test(expected = IndexOutOfBoundsException.class)
public void testShouldFail() {
get();
// This test pass since execution will never get past this line.
Assert.assertEquals(0, 1);
}
private Object get() {
throw new IndexOutOfBoundsException();
}
Compliant solution
// This test correctly fails.
@Test
public void testToString() {
Object obj = get();
Assert.assertThrows(IndexOutOfBoundsException.class, () -> obj.toString());
Assert.assertEquals(0, 1);
}
@Test
public void testShouldFail() {
Object obj = get();
try {
obj.toString();
Assert.fail("Expected an IndexOutOfBoundsException to be thrown");
} catch (IndexOutOfBoundsException e) {}
Assert.assertEquals(0, 1); // Correctly fails.
}
