SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
Go

Go static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your GO code

  • All rules 70
  • Vulnerability20
  • Bug7
  • Security Hotspot14
  • Code Smell29
Filtered: 2 rules found
design
    Impact
      Clean code attribute
        1. Two branches in a conditional structure should not have exactly the same implementation

           Code Smell
        2. String literals should not be duplicated

           Code Smell

        Two branches in a conditional structure should not have exactly the same implementation

        adaptability - distinct
        maintainability
        Code Smell
        • design
        • suspicious

        Why is this an issue?

        More Info

        When the same code is duplicated in two or more separate branches of a conditional, it can make the code harder to understand, maintain, and can potentially introduce bugs if one instance of the code is changed but others are not.

        Having two cases in a switch statement or two branches in an if chain with the same implementation is at best duplicate code, and at worst a coding error.

        if a >= 0 && a < 10 {
        	doFirstThing()
        	doSomething()
        } else if a >= 10 && a < 20 {
        	doSomethingElse()
        } else if a >= 20 && a < 50 { // Noncompliant; duplicates first condition
        	doFirstThing()
        	doSomething()
        } else {
        	doTheRest()
        }
        
        switch i {
        case 1:
        	doFirstThing()
        	doSomething()
        case 2:
        	doSomethingElse()
        case 3: // Noncompliant; duplicates case 1's implementation
        	doFirstThing()
        	doSomething()
        default:
        	doTheRest()
        }
        

        If the same logic is truly needed for both instances, then:

        • in an if chain they should be combined
        if (a >= 0 && a < 10) || (a >= 20 && a < 50) {
        	doFirstThing()
        	doSomething()
        } else if a >= 10 && a < 20 {
        	doSomethingElse()
        } else {
        	doTheRest()
        }
        
        • for a switch, the values should be put in the case expression list.
        switch i {
        case 1, 3:
        	doFirstThing()
        	doSomething()
        case 2:
        	doSomethingElse()
        default:
        	doTheRest()
        }
        

        Exceptions

        Blocks in an if chain or case blocks that contain a single line of code are ignored.

        if a == 1 {
          doSomething()  //no issue, usually this is done on purpose to increase the readability
        } else if a == 2 {
          doSomethingElse()
        } else {
          doSomething()
        }
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube Community BuildAnalyze code in your
          on-premise CI
          Available Since
          9.1
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use