Using the same value on both sides of a binary operator is a code defect. In the case of logical operators, it is either a copy/paste error and,
therefore, a bug, or it is simply duplicated code and should be simplified. In the case of bitwise operators and most binary mathematical operators,
having the same value on both sides of an operator yields predictable results and should be simplified as well.
Note that this rule will raise issues on a == a
and a != a
expressions which are sometime used to detect NaN
values. It is recommended to use instead math.IsNaN()
or an equivalent function. This will
improve code readability.
Noncompliant code example
func main() {
v1 := (true && false) && (true && false) // Noncompliant
}
Compliant solution
func main() {
v1 := (true && false) // Compliant
}
Exceptions
This rule ignores *
, +
, <<
and =
.