A for loop stop condition should test the loop counter against an invariant value (i.e. one that is true at both the beginning and
ending of every loop iteration). Ideally, this means that the stop condition is set to a local variable just before the loop begins.
Stop conditions that are not invariant are slightly less efficient, as well as being difficult to understand and maintain, and likely lead to the
introduction of errors in the future.
This rule tracks three types of non-invariant stop conditions:
- When the loop counters are updated in the body of the
for loop
- When the stop condition depend upon a method call
- When the stop condition depends on an object property, since such properties could change during the execution of the loop.
Noncompliant code example
for (var i = 0; i < 10; i++) {
...
i = i - 1; // Noncompliant
...
}
for (var i = 0; i < getMaximumNumber(); i++) {...}
Compliant solution
int stopCondition = getMaximumNumber();
for (var i = 0; i < stopCondition; i++) {...}
