SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C#

C# static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C# code

  • All rules 493
  • Vulnerability46
  • Bug88
  • Security Hotspot24
  • Code Smell335

  • Quick Fix 61
Filtered: 9 rules found
tests
    Impact
      Clean code attribute
        1. Test method signatures should be correct

           Code Smell
        2. "[ExpectedException]" should not be used

           Code Smell
        3. Assertion arguments should be passed in the correct order

           Code Smell
        4. Assertions should be complete

           Code Smell
        5. "Thread.Sleep" should not be used in tests

           Code Smell
        6. Literal boolean values should not be used in assertions

           Code Smell
        7. Tests should include assertions

           Code Smell
        8. Test classes should contain at least one test case

           Code Smell
        9. Tests should not be ignored

           Code Smell

        "Thread.Sleep" should not be used in tests

        intentionality - complete
        maintainability
        Code Smell
        • tests
        • bad-practice

        Why is this an issue?

        More Info

        Using Thread.Sleep in a test might introduce unpredictable and inconsistent results depending on the environment. Furthermore, it will block the thread, which means the system resources are not being fully used.

        [TestMethod]
        public void SomeTest()
        {
            Thread.Sleep(500); // Noncompliant
            // assertions...
        }
        

        An alternative is a task-based asynchronous approach, using async and await.

        More specifically the Task.Delay method should be used, because of the following advantages:

        • It is asynchronous: The thread will not be blocked, but instead will be reused by other operations
        • It is more precise in timing the delay than Thread.Sleep
        • It can be canceled and continued, which gives more flexibility and control in the timing of your code
        [TestMethod]
        public async Task SomeTest()
        {
            await Task.Delay(500);
            // assertions...
        }
        

        Another scenario is when some data might need to be mocked using Moq, and a delay needs to be introduced:

        [TestMethod]
        public void UserService_Test()
        {
            var userService = new Mock<UserService>();
            var expected = new User();
        
            userService
                .Setup(m => m.GetUserById(42))
                .Returns(() =>
                {
                    Thread.Sleep(500); // Noncompliant
                    return Task.FromResult(expected);
                });
        
            // assertions...
        }
        

        An alternative to Thread.Sleep while mocking with Moq is to use ReturnsAsync and pass the amount of time to delay there:

        [TestMethod]
        public void UserService_Test()
        {
            var userService = new Mock<UserService>();
            var expected = new User();
        
            userService
                .Setup(m => m.GetUserById(42))
                .ReturnsAsync(expected, TimeSpan.FromMilliseconds(500));
        
            // assertions...
        }
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube Community BuildAnalyze code in your
          on-premise CI
          Available Since
          10.2
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          10.2

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use