SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C#

C# static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C# code

  • All rules 493
  • Vulnerability46
  • Bug88
  • Security Hotspot24
  • Code Smell335

  • Quick Fix 61
Filtered: 9 rules found
tests
    Impact
      Clean code attribute
        1. Test method signatures should be correct

           Code Smell
        2. "[ExpectedException]" should not be used

           Code Smell
        3. Assertion arguments should be passed in the correct order

           Code Smell
        4. Assertions should be complete

           Code Smell
        5. "Thread.Sleep" should not be used in tests

           Code Smell
        6. Literal boolean values should not be used in assertions

           Code Smell
        7. Tests should include assertions

           Code Smell
        8. Test classes should contain at least one test case

           Code Smell
        9. Tests should not be ignored

           Code Smell

        Tests should include assertions

        adaptability - tested
        maintainability
        Code Smell
        • tests

        Why is this an issue?

        How can I fix it?

        More Info

        The rule targets test methods that lack an assertion and consist solely of an action and, optionally, a setup.

        [TestMethod]
        public void Add_SingleNumber_ReturnsSameNumber()
        {
            var stringCalculator = new StringCalculator();
            var actual = stringCalculator.Add("0");
        }
        

        Such tests only verify that the system under test does not throw any exceptions without providing any guarantees regarding the code’s behavior under test. Those tests increase the coverage without enforcing anything on the covered code, resulting in a false sense of security.

        The rule identifies a potential issue when no assertions are present in tests utilizing the following frameworks:

        • MSTest
        • NUnit
        • xUnit
        • FluentAssertions (4.x and 5.x)
        • NFluent
        • NSubstitute
        • Moq
        • Shoudly

        By enforcing the presence of assertions, this rule aims to enhance the reliability and comprehensiveness of tests by ensuring that they provide meaningful validation of the expected behavior.

        Exceptions

        Test methods that include a call to a custom assertion method will not raise any issues.

        How can you fix it?

        To address this issue, you should include assertions to validate the expected behavior. Choose an appropriate assertion method provided by your testing framework (such as MSTest, NUnit, xUnit) or select a suitable assertion library like FluentAssertions, NFluent, NSubstitute, Moq, or Shouldly.

        In addition to using built-in assertion methods, you also have the option to create custom assertion methods. To do this, declare an attribute named [AssertionMethodAttribute] and apply it to the respective method. This allows you to encapsulate specific validation logic within your custom assertion methods without raising the issue. Here’s an example:

        using System;
        using Microsoft.VisualStudio.TestTools.UnitTesting;
        
        [TestClass]
        public class CustomTestExample
        {
            [TestMethod]
            public void Add_SingleNumber_ReturnsSameNumber()
            {
                var stringCalculator = new StringCalculator();
                var actual = stringCalculator.Add("0");
                Validator.AssertCustomEquality(0, actual); // Compliant
            }
        }
        
        public static class Validator
        {
            [AssertionMethod]
            public static void AssertCustomEquality(int expected, int actual)
            {
                // ...
            }
        }
        
        public class AssertionMethodAttribute : Attribute { }
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube Community BuildAnalyze code in your
          on-premise CI
          Available Since
          9.1
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use