SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C#

C# static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C# code

  • All rules 493
  • Vulnerability46
  • Bug88
  • Security Hotspot24
  • Code Smell335

  • Quick Fix 61
Filtered: 12 rules found
design
    Impact
      Clean code attribute
        1. Interfaces for durable entities should satisfy the restrictions

           Code Smell
        2. Client instances should not be recreated on each Azure Function invocation

           Code Smell
        3. Multidimensional arrays should not be used

           Code Smell
        4. Strings or integral types should be used for indexers

           Code Smell
        5. Classes should not have only "private" constructors

           Bug
        6. Interfaces should not simply inherit from base interfaces with colliding members

           Code Smell
        7. Methods should not return values that are never used

           Code Smell
        8. Inner class members should not shadow outer class "static" or type members

           Code Smell
        9. "interface" instances should not be cast to concrete types

           Code Smell
        10. Two branches in a conditional structure should not have exactly the same implementation

           Code Smell
        11. String literals should not be duplicated

           Code Smell
        12. Utility classes should not have public constructors

           Code Smell

        Two branches in a conditional structure should not have exactly the same implementation

        adaptability - distinct
        maintainability
        Code Smell
        • design
        • suspicious

        Why is this an issue?

        More Info

        When the same code is duplicated in two or more separate branches of a conditional, it can make the code harder to understand, maintain, and can potentially introduce bugs if one instance of the code is changed but others are not.

        Having two cases in a switch statement or two branches in an if chain with the same implementation is at best duplicate code, and at worst a coding error.

        if (a >= 0 && a < 10)
        {
          DoFirst();
          DoTheThing();
        }
        else if (a >= 10 && a < 20)
        {
          DoTheOtherThing();
        }
        else if (a >= 20 && a < 50) // Noncompliant; duplicates first condition
        {
          DoFirst();
          DoTheThing();
        }
        
        switch (i)
        {
          case 1:
            DoFirst();
            DoSomething();
            break;
          case 2:
            DoSomethingDifferent();
            break;
          case 3:  // Noncompliant; duplicates case 1's implementation
            DoFirst();
            DoSomething();
            break;
          default:
            DoTheRest();
        }
        

        If the same logic is truly needed for both instances, then:

        • in an if chain they should be combined
        if ((a >= 0 && a < 10) || (a >= 20 && a < 50))
        {
          DoFirst();
          DoTheThing();
        }
        else if (a >= 10 && a < 20)
        {
          DoTheOtherThing();
        }
        
        • for a switch, one should fall through to the other
        switch (i)
        {
          case 1:
          case 3:
            DoFirst();
            DoSomething();
            break;
          case 2:
            DoSomethingDifferent();
            break;
          default:
            DoTheRest();
        }
        

        Exceptions

        The rule does not raise an issue for blocks in an if chain that contain a single line of code. The same applies to blocks in a switch statement that contain a single line of code with or without a following break.

        if (a >= 0 && a < 10)
        {
          DoTheThing();
        }
        else if (a >= 10 && a < 20)
        {
          DoTheOtherThing();
        }
        else if (a >= 20 && a < 50)    //no issue, usually this is done on purpose to increase the readability
        {
          DoTheThing();
        }
        

        However, this exception does not apply to if chains without an else statement or to a switch statement without a default clause when all branches have the same single line of code.

        if (a == 1)
        {
          DoSomething();  // Noncompliant, this might have been done on purpose but probably not
        }
        else if (a == 2)
        {
          DoSomething();
        }
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube Community BuildAnalyze code in your
          on-premise CI
          Available Since
          9.1
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use