SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C#

C# static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C# code

  • All rules 493
  • Vulnerability46
  • Bug88
  • Security Hotspot24
  • Code Smell335

  • Quick Fix 61
Filtered: 27 rules found
clumsy
    Impact
      Clean code attribute
        1. "Trace.WriteLineIf" should not be used with "TraceSwitch" levels

           Code Smell
        2. Arrays should not be created for params parameters

           Code Smell
        3. Jump statements should not be redundant

           Code Smell
        4. Empty "default" clauses should be removed

           Code Smell
        5. Empty "case" clauses that fall through to the "default" should be omitted

           Code Smell
        6. "string.ToCharArray()" and "ReadOnlySpan<T>.ToArray()" should not be called redundantly

           Bug
        7. Redundant property names should be omitted in anonymous classes

           Code Smell
        8. Declarations and initializations should be as concise as possible

           Code Smell
        9. "string.IsNullOrEmpty" should be used

           Code Smell
        10. Default parameter values should not be passed as arguments

           Code Smell
        11. Constructor and destructor declarations should not be redundant

           Code Smell
        12. The simplest possible condition syntax should be used

           Code Smell
        13. LINQ expressions should be simplified

           Code Smell
        14. Sequential tests should not check the same condition

           Code Smell
        15. "catch" clauses should do more than rethrow

           Code Smell
        16. Redundant modifiers should not be used

           Code Smell
        17. "try" statements with identical "catch" and/or "finally" blocks should be merged

           Code Smell
        18. Trivial properties should be auto-implemented

           Code Smell
        19. Runtime type checking should be simplified

           Code Smell
        20. Classes should not be empty

           Code Smell
        21. Inheritance list should not be redundant

           Code Smell
        22. Redundant casts should not be used

           Code Smell
        23. "ToString()" calls should not be redundant

           Code Smell
        24. A "while" loop should be used instead of a "for" loop

           Code Smell
        25. Overriding members should do more than simply call the same member in the base class

           Code Smell
        26. Boolean literals should not be redundant

           Code Smell
        27. Mergeable "if" statements should be combined

           Code Smell

        Runtime type checking should be simplified

        intentionality - clear
        maintainability
        Code Smell
        Quick FixIDE quick fixes available with SonarLint
        • clumsy

        Why is this an issue?

        To check the type of an object there are several options:

        • expr is SomeType or expr.GetType() == typeof(SomeType) if the type is known at compile time,
        • typeInstance.IsInstanceOfType(expr) if the type is calculated during runtime.

        If runtime calculated Types need to be compared:

        • typeInstance1.IsAssignableFrom(typeInstance2).

        Depending on whether the type is returned by a GetType() or typeof() call, the IsAssignableFrom() and IsInstanceOfType() might be simplified. Similarly, if the type is sealed, the type comparison with == can be converted to an is call. Simplifying the calls also make null checking unnecessary because both is and IsInstanceOfType performs it already.

        Finally, utilizing the most concise language constructs for type checking makes the code more readable, so

        • expr as T != null checks should be simplified to expr is T, and
        • expr is T should be converted to expr != null, when expr is of type T.

        Noncompliant code example

        class Fruit { }
        sealed class Apple : Fruit { }
        
        class Program
        {
          static void Main()
          {
            var apple = new Apple();
            var b = apple != null && apple.GetType() == typeof (Apple); // Noncompliant
            b = typeof(Apple).IsInstanceOfType(apple); // Noncompliant
            if (apple != null)
            {
              b = typeof(Apple).IsAssignableFrom(apple.GetType()); // Noncompliant
            }
            var appleType = typeof (Apple);
            if (apple != null)
            {
              b = appleType.IsAssignableFrom(apple.GetType()); // Noncompliant
            }
        
            Fruit f = apple;
            if (f as Apple != null) // Noncompliant
            {
            }
            if (apple is Apple) // Noncompliant
            {
            }
          }
        }
        

        Compliant solution

        class Fruit { }
        sealed class Apple : Fruit { }
        
        class Program
        {
          static void Main()
          {
            var apple = new Apple();
            var b = apple is Apple;
            b = apple is Apple;
            b = apple is Apple;
            var appleType = typeof(Apple);
            b = appleType.IsInstanceOfType(apple);
        
            Fruit f = apple;
            if (f is Apple)
            {
            }
            if (apple != null)
            {
            }
          }
        }
        

        Exceptions

        Calling GetType on an object of Nullable<T> type returns the underlying generic type parameter T, thus a comparison with typeof(Nullable<T>) can’t be simplified to use the is operator, which doesn’t make difference between T and T?.

        int? i = 42;
        bool condition = i.GetType() == typeof(int?); // false;
        condition = i is int?; // true
        

        No issue is reported on the following expressions:

        • expr is T when either operand of the is operator is a value type. In that case CS0183 or CS0184 reports
        • expr is object, as this is a common and efficient pattern to do null checks
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube Community BuildAnalyze code in your
          on-premise CI
          Available Since
          9.1
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use