SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C++

C++ static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C++ code

  • All rules 674
  • Vulnerability13
  • Bug139
  • Security Hotspot19
  • Code Smell503

  • Quick Fix 91
Filtered: 45 rules found
symbolic-execution
    Impact
      Clean code attribute
        1. The address of an automatic object should not be assigned to another object that may persist after the first object has ceased to exist

           Bug
        2. Variables should be initialized before use

           Bug
        3. Variables should not be accessed outside of their scope

           Bug
        4. Well-defined type-punning method should be used instead of a union-based one

           Bug
        5. "std::cmp_*" functions should be used to compare unsigned values with negative values

           Bug
        6. "std::cmp_*" functions should be used to compare signed and unsigned values

           Code Smell
        7. Account validity should be verified when authenticating users with PAM

           Vulnerability
        8. Changing directories improperly when using "chroot" is security-sensitive

           Security Hotspot
        9. POSIX functions should not be called with arguments that trigger buffer overflows

           Vulnerability
        10. Immediately dangling references and pointers should not be created

           Bug
        11. Server hostnames should be verified during SSL/TLS connections

           Vulnerability
        12. "pthread_mutex_t" should be unlocked in the reverse order they were locked

           Bug
        13. Only valid arguments should be passed to UNIX/POSIX functions

           Code Smell
        14. "pthread_mutex_t" should be properly initialized and destroyed

           Bug
        15. "pthread_mutex_t" should not be locked when already locked, or unlocked when already unlocked

           Bug
        16. Only valid arguments should be passed to stream functions

           Code Smell
        17. Using publicly writable directories is security-sensitive

           Security Hotspot
        18. Using clear-text protocols is security-sensitive

           Security Hotspot
        19. Blocking functions should not be called inside critical sections

           Code Smell
        20. Return value of "setuid" family of functions should always be checked

           Code Smell
        21. Size of variable length arrays should be greater than zero

           Code Smell
        22. "mktemp" family of functions templates should have at least six trailing "X"s

           Code Smell
        23. Appropriate size arguments should be passed to "strncat" and "strlcpy"

           Code Smell
        24. Moved-from objects should not be relied upon

           Code Smell
        25. Server certificates should be verified during SSL/TLS connections

           Vulnerability
        26. Weak SSL/TLS protocols should not be used

           Vulnerability
        27. Integral operations should not overflow

           Bug
        28. Parameter values should be appropriate

           Bug
        29. Stack allocated memory and non-owned memory should not be freed

           Bug
        30. Closed resources should not be accessed

           Bug
        31. Dynamically allocated memory should be released

           Bug
        32. Freed memory should not be used

           Bug
        33. Memory locations should not be released more than once

           Bug
        34. Memory access should be explicitly bounded to prevent buffer overflows

           Bug
        35. Zero should not be a possible denominator

           Bug
        36. XML parsers should not be vulnerable to XXE attacks

           Vulnerability
        37. "nonnull" parameters and return values of "returns_nonnull" functions should not be null

           Bug
        38. Null pointers should not be dereferenced

           Bug
        39. Member variables should be initialized

           Bug
        40. Resources should be closed

           Bug
        41. Unused assignments should be removed

           Code Smell
        42. Appropriate memory de-allocation should be used

           Bug
        43. An object shall not be accessed outside of its lifetime

           Bug
        44. Reads and writes on the same file stream shall be separated by a positioning operation

           Bug
        45. The value of an object must not be read before it has been set

           Bug

        Moved-from objects should not be relied upon

        intentionality - logical
        maintainability
        Code Smell
        • symbolic-execution
        • cert
        • since-c++11

        Relying on an object that has been moved-from leads to undefined behavior in most cases.

        Why is this an issue?

        How can I fix it?

        More Info

        After a move took place, the object that has been moved-from is left in a valid but unspecified state. Even if in a valid state, the fact of an object being in an unspecified state may lead to undefined behavior.

        Move construction and its respective move semantics has been introduced in C++11. Moving objects becomes interesting if one wishes to get an object into a different scope, while no longer requiring the original object. While one would previously need to make a potentially expensive copy to get an object into another scope and then destroy the original, move constructors allow one to move objects without performing a copy. Move constructors are typically implemented by "stealing" the resources held by another object specified as the move constructor’s parameter, rather than making a copy. "Stealing" resources (e.g. memory) from another object is oftentimes much more efficient than making a copy and destroying the original, and can frequently be implemented by reassigning a few pointer variables.

        Move-assignment operators behave analogously, except that they are used once the object that is moved-to has already been constructed. In contrast to copy-assignment operators, a move-assignment operator too "steals" the moved-from object’s resources without the need for making a potentially expensive copy.

        What is the potential impact?

        Using an object after it has been moved-from typically leads to undefined behavior.

        For programs that exercise undefined behavior, the compiler is no longer bound by the language specification. The application may crash or, even worse, the application may appear to execute correctly while losing data or producing incorrect results.

        Trying to access an object that has been moved-from frequently ends up in a null-pointer dereference, since any pointers to the resources that have been "stolen" are set to nullptr as part of the move construction or move assignment.

        Exceptions

        There are some C++ standard template library types, such as std::unique_ptr, for which the moved-from state is fully specified.

        Exemplary type with move operations

        The DynamicIntArray type defined in the following manages memory (i.e., a resource), and shall serve as an example that showcases how move operations "steal" another object’s resources and how they differ from making copies.

        While the copy constructor does make a full copy by allocating memory and then copying the other object’s array values into the freshly allocated memory, the move constructor only assigns the pointer to point to other's dynamically allocated memory. It then sets the pointer of the other object to nullptr to allow its correct cleanup by the destructor of the DynamicIntArray type.

        The implementations for the copy- and move-assignment operators are similar with the main difference being that the objects have already been constructed.

        #include <algorithm> // std::copy, std::fill
        #include <memory>    // std::move
        
        class DynamicIntArray {
          size_t size;
          int *data;
        
        public:
          explicit DynamicIntArray(size_t size, int initial_value)
              : size(size), data(new int[size]) {
            std::fill(data, &data[size], initial_value);
          }
          ~DynamicIntArray() {
            delete[] data;
            size = 0;
          }
          // Copy constructor (copies object)
          DynamicIntArray(DynamicIntArray const &other)
              : size(other.size), data(new int[other.size]) {
            std::copy(other.data, &other.data[size], data);
          }
          // Move constructor ("steals" data, no allocation or copy necessary)
          DynamicIntArray(DynamicIntArray &&other) noexcept
              : size(other.size), data(other.data) {
            // Ensure that the moved-from object `other` can be safely destroyed (using
            // the destructor that calls to delete[]).
            other.data = nullptr;
            other.size = 0;
          }
          //
          // Copy- and move-assignment operators are invoked, if _this_ object has
          // already been constructed.
          //
          // Copy-assignment operator (copies object)
          DynamicIntArray &operator=(DynamicIntArray const &other) {
            // If the number of elements are equal, we can re-use the existing memory.
            if (size == other.size) {
              std::copy(other.data, &other.data[other.size], data);
              return *this;
            }
            // Otherwise, we need to clean-up and re-allocate the required amount of
            // memory.
            delete[] data;
            data = new int[other.size];
            size = other.size;
            std::copy(other.data, &other.data[size], data);
            return *this;
          }
          // Move-assignment operator ("steals" data, no allocation or copy necessary)
          DynamicIntArray &operator=(DynamicIntArray &&other) noexcept {
            delete[] data; // Clean-up our own data before we "steal" from `other`.
            data = other.data;
            size = other.size;
            // Ensure that the moved-from object `other` can be safely destroyed (using
            // the destructor that calls to delete[]).
            other.data = nullptr;
            other.size = 0;
            return *this;
          }
        
          int &getValueAt(size_t idx) { return data[idx]; }
        };
        
        int main() {
          DynamicIntArray a{/*size=*/128, /*initial_value=*/42};
          DynamicIntArray b = a;            // Copy constructor.
          DynamicIntArray c = std::move(b); // Move constructor.
          // Construct two more objects.
          DynamicIntArray d{/*size=*/4, /*initial_value=*/0};
          DynamicIntArray e{/*size=*/8, /*initial_value=*/9001};
          // Use the assignment operators.
          a = d;            // Copy-assignment operator.
          c = std::move(e); // Move-assignment operator.
          int i = b.getValueAt(0); // Noncompliant: `b` has been moved-from during construction of `c`.
          int j = e.getValueAt(0); // Noncompliant: `e` has been moved-from during move-assignment to `c`.
          return i + j;
        }
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use