SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C++

C++ static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C++ code

  • All rules 798
  • Vulnerability14
  • Bug173
  • Security Hotspot19
  • Code Smell592

  • Quick Fix 99
Filtered: 79 rules found
suspicious
    Impact
      Clean code attribute
        1. "offsetof" macro should not be used

           Code Smell
        2. "errno" should not be used

           Code Smell
        3. Function names should be used either as a call with a parameter list or with the "&" operator

           Code Smell
        4. "enum" values should not be used as operands to built-in operators other than [ ], =, ==, !=, unary &, and the relational operators <, <=, >, >=

           Code Smell
        5. "bool" expressions should not be used as operands to built-in operators other than =, &&, ||, !, ==, !=, unary &, and the conditional operator

           Code Smell
        6. A cast shall not remove any const or volatile qualification from the type of a pointer or reference

           Code Smell
        7. Trigraphs should not be used

           Code Smell
        8. std::string_view::data() should not be passed to API expecting C-style strings

           Code Smell
        9. The condition of "assert" should not be trivially true

           Code Smell
        10. "std::format" numeric types should be 0-padded using the numerical padding and not the character padding

           Bug
        11. "std::format" should not have unused arguments

           Code Smell
        12. Type-constraints should not be used for forwarding reference parameters

           Bug
        13. Perfect forwarding constructors should be constrained

           Bug
        14. Requires-expression should not contain unevaluated concept checks or type predicates

           Bug
        15. Coroutine should have co_return on each execution path or provide return_void

           Bug
        16. Thread local variables should not be used in coroutines

           Code Smell
        17. The return value of "std::move" should be used in a function

           Code Smell
        18. "std::to_address" should be used to convert iterators to raw pointers

           Code Smell
        19. [[nodiscard]] should be used when the return value of a function should not be ignored

           Code Smell
        20. "dynamic_cast" should be used for downcasting

           Code Smell
        21. Pointers or references obtained from aliased smart pointers should not be used as function parameters

           Code Smell
        22. "#pragma pack" should be used correctly

           Bug
        23. Only valid arguments should be passed to UNIX/POSIX functions

           Code Smell
        24. Only valid arguments should be passed to stream functions

           Code Smell
        25. "Forwarding references" parameters should be used only to forward parameters

           Code Smell
        26. The order for arguments of the same type in a function call should be obvious

           Code Smell
        27. "std::move" and "std::forward" should not be confused

           Bug
        28. "std::move" should only be used where moving can happen

           Code Smell
        29. "^" should not be confused with exponentiation

           Code Smell
        30. An object with pointer type shall not be converted to an unrelated pointer type, either directly or indirectly

           Code Smell
        31. Size of variable length arrays should be greater than zero

           Code Smell
        32. "mktemp" family of functions templates should have at least six trailing "X"s

           Code Smell
        33. Unevaluated operands should not have side effects

           Code Smell
        34. Size argument of memory functions should be consistent

           Code Smell
        35. Return value of "nodiscard" functions should not be ignored

           Code Smell
        36. Implicit casts should not lower precision

           Code Smell
        37. "reinterpret_cast" should be used carefully

           Bug
        38. Appropriate size arguments should be passed to "strncat" and "strlcpy"

           Code Smell
        39. User-defined types should not be passed as variadic arguments

           Bug
        40. RAII objects should not be temporary

           Bug
        41. "std::auto_ptr" should not be used

           Bug
        42. Methods should not have identical implementations

           Code Smell
        43. Array values should not be replaced unconditionally

           Bug
        44. A conditionally executed single line should be denoted by indentation

           Code Smell
        45. Conditionals should start on new lines

           Code Smell
        46. "case" ranges should cover multiple values

           Code Smell
        47. Default capture should not be used

           Code Smell
        48. "switch" statements should cover all cases

           Code Smell
        49. Redundant pointer operator sequences should be removed

           Code Smell
        50. Members should be initialized in the order they are declared

           Code Smell
        51. Conditionally executed code should be reachable

           Bug
        52. Exceptions should not be ignored

           Code Smell
        53. Flexible array members should not be declared

           Code Smell
        54. Track parsing failures

           Code Smell
        55. Recursion should not be infinite

           Bug
        56. Two branches in a conditional structure should not have exactly the same implementation

           Code Smell
        57. Pre-defined macros should not be defined, redefined or undefined

           Code Smell
        58. Switch cases should end with an unconditional "break" statement

           Code Smell
        59. C-style memory allocation routines should not be used

           Code Smell
        60. "switch" statements should not contain non-case labels

           Code Smell
        61. Methods should not be empty

           Code Smell
        62. Assignments should not be made from within conditions

           Code Smell
        63. Variables should not be shadowed

           Code Smell
        64. Nested blocks of code should not be left empty

           Code Smell
        65. "using namespace" directives should not be used in header files

           Code Smell
        66. "Assignment" between numeric types shall be appropriate

           Code Smell
        67. There shall be no conversion from type "bool"

           Code Smell
        68. "Exception-unfriendly" functions shall be "noexcept"

           Code Smell
        69. The result of "std::remove", "std::remove_if", "std::unique" and "empty" shall be "used"

           Bug
        70. The argument to "std::move" shall be a non-const "lvalue"

           Code Smell
        71. A comparison of a "potentially virtual" pointer to member function shall only be with "nullptr"

           Bug
        72. Within an enumerator list, the value of an implicitly-specified "enumeration constant" shall be unique

           Code Smell
        73. A conversion from function type to pointer-to-function type shall only occur in appropriate contexts

           Code Smell
        74. An assignment operator shall not assign the address of an object with automatic storage duration to an object with a greater lifetime

           Code Smell
        75. The result of an assignment operator should not be "used"

           Code Smell
        76. An unsigned arithmetic operation with constant operands should not wrap

           Bug
        77. The built-in unary "-" operator should not be applied to an expression of unsigned type

           Bug
        78. A cast shall not remove any "const" or "volatile" qualification from the type accessed via a pointer or by reference

           Code Smell
        79. All "declarations" of a variable or function shall have the same type

           Bug

        "Exception-unfriendly" functions shall be "noexcept"

        intentionality - logical
        maintainability
        reliability
        Code Smell
        • suspicious
        • misra-c++2023
        • misra-required

        Why is this an issue?

        More Info

        This rule is part of MISRA C++:2023.

        Usage of this content is governed by Sonar’s terms and conditions. Redistribution is prohibited.

        Rule 18.4.1 - Exception-unfriendly functions shall be noexcept

        [support.start.term] Implementation-defined 9.1

        Category: Required

        Analysis: Decidable,Single Translation Unit

        Amplification

        The following functions are considered as exception-unfriendly and are required to be implicitly or explicitly noexcept:

        • Any function or constructor directly called (explicitly or implicitly) to initialize a non-constexpr, non-local variable with static or thread storage duration;
        • All destructors;
        • All copy-constructors of an exception object;
        • All move constructors;
        • All move assignment operators;
        • All functions named "swap";

        Additionally, the arguments passed to extern "C" functions std::set_terminate, std::atexit or std::at_quick_exit shall be convertible to function pointers to noexcept functions.

        This rule does not apply to any member function defined as = delete.

        Rationale

        When an exception is thrown, the call stack is unwound up to the point where the exception is to be handled. The destructors for all automatic objects declared between the point where the exception is thrown and where it is to be handled will be invoked. If one of these destructors exits with an exception, then the program will terminate in an implementation-defined manner. Requiring destructors to be noexcept and enforcing M23_201: MISRA C++ 2023 Rule 18.5.1 ensures that std::terminate does not get called, as required by M23_202: MISRA C++ 2023 Rule 18.5.2.

        Exceptions from destructors are also undesirable for objects that are at non-local scope or that are declared static, as they are destroyed in a "close-down" phase after main terminates. There is nowhere within the code that a handler can be placed to catch any exception that may be thrown, leading to a call to std::terminate. Similarly, non-local objects may be constructed before main starts, meaning that any exception thrown during their construction cannot be caught.

        Most destructors are noexcept by default, meaning that the omission of an explicit noexcept-specifier is generally compliant.

        Note: this rule does not apply to the constructors of classes used to construct local objects with static storage duration, as these are constructed the first time their owning function is called (i.e. after main has started), allowing exceptions thrown by them to be caught.

        When an exception is thrown, the exception object is copy-initialized from the operand of the throw-expression. If an exception is thrown during this copy, this is the exception that will be propagated, which may surprise developers. Furthermore, if a catch handler catches by value (which is prohibited by M23_196: MISRA C++ 2023 Rule 18.3.2), another copy-initialization will happen. If this throws, the program will terminate. It is therefore better to ensure that exception objects' copy constructors do not throw.

        Functions named "swap" are conventionally used as customization points for std::swap. The C++ Standard Library containers and algorithms will not work correctly if swapping of two elements exits with an exception.

        Non-throwing "swap" functions are also important when implementing the strong exception safety guarantee in a copy (or move) assignment operator. Similarly, move constructors and move assignment operators are usually expected to be non-throwing. If they are not declared noexcept, strong exception safety is more difficult to achieve. Furthermore, algorithms may choose a different, possibly more expensive, code path if move operations are not noexcept.

        Functions passed as arguments to extern "C" functions are likely to be invoked from C code that is not able to handle exceptions.

        The C++ Standard states that if a function registered using std::atexit or std::at_quick_exit is called and exits with an exception, then std::terminate is called. The C++ Standard requires that a terminate handler set via std::set_terminate must not return to its caller, including with an exception (see [terminate.handler]).

        Example

        class C1
        {
        public:
          C1(){}                           // Compliant - never used at non-local scope
        
          ~C1(){}                          // Compliant - noexcept by default
        };
        
        class C2
        {
        public:
          C2(){}                           // Not noexcept - see declaration of c2 below
          C2( C2 && other ) {}             // Non-compliant - move constructor
        
          C2 & operator=( C2 && other );   // Non-compliant - move assignment
        
          ~C2() noexcept( true ) {}        // Compliant
        
          friend void swap( C2 &, C2 & );  // Non-compliant - function named swap
        };
        
        C2 c2;                             // Non-compliant - construction is non-local
        
        
        class C3
        {
        public:
          C3(){}                           // Compliant - c3 in foo not in non-local scope
        
          ~C3() noexcept( false ) {}       // Non-compliant
        };
        
        class MyException : public std::exception       // Non-compliant - implicit copy
        {                                               // constructor is noexcept( false )
        public:
          MyException ( std::string const & sender );   // Rule does not apply
          const char * what() const noexcept override;
        
          std::string sender;
        };
        
        void foo()
        {
          static C3 c3;                    // Compliant - constructed on first call to foo
        
          throw MyException( "foo" );
        }
        
        void exit_handler1();              // Non-compliant - passed to atexit
        
        void exit_handler2() noexcept;     // Compliant - also passed to atexit
        
        
        int main()
        {
          try
          {
            const int32_t result1 = std::atexit( exit_handler1 );
            const int32_t result2 = std::atexit( exit_handler2 );
            C1 c1;
        
            foo();                         // Any exception thrown will be caught below
          }
          catch ( ... ) {}
        }
        
        extern "C"
        {
          void f( void( *func )() );
        }
        
        f( [](){} );                       // Non-compliant - function passed to extern "C"
        

        Copyright The MISRA Consortium Limited © 2023

          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI

        © 2025 SonarSource Sàrl. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use