SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C++

C++ static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C++ code

  • All rules 674
  • Vulnerability13
  • Bug139
  • Security Hotspot19
  • Code Smell503

  • Quick Fix 91
Filtered: 24 rules found
since-c++17
    Impact
      Clean code attribute
        1. The optional init-statement in a control statements should only be used to declare variables

           Code Smell
        2. Assigning to an optional should directly target the optional

           Bug
        3. "try_emplace" should be used with "std::map" and "std::unordered_map"

           Code Smell
        4. "auto" should be used for non-type template parameter

           Code Smell
        5. Use "std::variant" instead of unions with non-trivial types.

           Code Smell
        6. "std::optional" member function "value_or" should be used

           Code Smell
        7. "std::byte" should be used when you need byte-oriented memory access

           Code Smell
        8. Inline variables should be used to declare global variables in header files

           Code Smell
        9. "if constexpr" should be preferred to overloading for metaprogramming

           Code Smell
        10. "[*this]" should be used to capture the current object by copy

           Code Smell
        11. "std::uncaught_exception" should not be used

           Code Smell
        12. "static_assert" with no message should be used over "static_assert" with empty or redundant message

           Code Smell
        13. Redundant class template arguments should not be used

           Code Smell
        14. "std::filesystem::path" should be used to represent a file path

           Code Smell
        15. "std::string_view" should be used to pass a read-only string to a function

           Code Smell
        16. Fold expressions should be used instead of recursive template instantiations

           Code Smell
        17. [[nodiscard]] should be used when the return value of a function should not be ignored

           Code Smell
        18. "as_const" should be used to make a value constant

           Code Smell
        19. Structured binding should be used

           Code Smell
        20. "if" and "switch" initializer should be used to reduce scope of variables

           Code Smell
        21. "std::visit" should be used to switch on the type of the current value in a "std::variant"

           Code Smell
        22. "std::scoped_lock" should be created with constructor arguments

           Bug
        23. "std::scoped_lock" should be used instead of "std::lock_guard"

           Code Smell
        24. Concise syntax should be used for concatenatable namespaces

           Code Smell

        The optional init-statement in a control statements should only be used to declare variables

        intentionality - clear
        maintainability
        Code Smell
        • pitfall
        • since-c++17

        Why is this an issue?

        How can I fix it?

        Since C++17, it is possible to add an initialization to an if or a switch, and this possibility has been extended to range-based for loops in C++20.

        The intended use case of this feature is to declare and initialize variables that can be used in the condition or the range but whose scope does not extend beyond the body of the control-flow statement.

        For instance, in this compliant code, the intent is to lock the mutex associated with the object obj while manipulating this object and unlock it immediately after. A lock object is, therefore, declared in the initialization of the condition.

        if (std::scoped_lock lock(obj.getMutex()); obj.isVisible()) {
          obj.draw();
        }
        

        However, the language’s syntax also allows simple expressions to be written in this place as well as using declarations since C++23. This leads to code that is more complex to read for no real benefits. In some cases, it can hide nasty bugs. Let’s revisit the previous example:

        if (std::scoped_lock (obj.getMutex()); obj.isVisible()) {
          obj.draw();
        }
        

        This very similar-looking code does not declare a variable in the initialization part of the if. Instead, it creates a temporary lock object that is then immediately discarded. The mutex is unlocked before isVisible or draw are called.

        Note: A classical for loop presents the same flexibility for its initialization part (the first part of the loop). However, since the initialization part is not optional, it is common practice to use it for simple expressions and not only variable declarations. So, this rule does not apply to classical for loops.

          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          10.7

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use