SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C++

C++ static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C++ code

  • All rules 674
  • Vulnerability13
  • Bug139
  • Security Hotspot19
  • Code Smell503

  • Quick Fix 91
Filtered: 24 rules found
since-c++17
    Impact
      Clean code attribute
        1. The optional init-statement in a control statements should only be used to declare variables

           Code Smell
        2. Assigning to an optional should directly target the optional

           Bug
        3. "try_emplace" should be used with "std::map" and "std::unordered_map"

           Code Smell
        4. "auto" should be used for non-type template parameter

           Code Smell
        5. Use "std::variant" instead of unions with non-trivial types.

           Code Smell
        6. "std::optional" member function "value_or" should be used

           Code Smell
        7. "std::byte" should be used when you need byte-oriented memory access

           Code Smell
        8. Inline variables should be used to declare global variables in header files

           Code Smell
        9. "if constexpr" should be preferred to overloading for metaprogramming

           Code Smell
        10. "[*this]" should be used to capture the current object by copy

           Code Smell
        11. "std::uncaught_exception" should not be used

           Code Smell
        12. "static_assert" with no message should be used over "static_assert" with empty or redundant message

           Code Smell
        13. Redundant class template arguments should not be used

           Code Smell
        14. "std::filesystem::path" should be used to represent a file path

           Code Smell
        15. "std::string_view" should be used to pass a read-only string to a function

           Code Smell
        16. Fold expressions should be used instead of recursive template instantiations

           Code Smell
        17. [[nodiscard]] should be used when the return value of a function should not be ignored

           Code Smell
        18. "as_const" should be used to make a value constant

           Code Smell
        19. Structured binding should be used

           Code Smell
        20. "if" and "switch" initializer should be used to reduce scope of variables

           Code Smell
        21. "std::visit" should be used to switch on the type of the current value in a "std::variant"

           Code Smell
        22. "std::scoped_lock" should be created with constructor arguments

           Bug
        23. "std::scoped_lock" should be used instead of "std::lock_guard"

           Code Smell
        24. Concise syntax should be used for concatenatable namespaces

           Code Smell

        Use "std::variant" instead of unions with non-trivial types.

        adaptability - focused
        maintainability
        Code Smell
        • since-c++17
        • clumsy
        • pitfall

        Why is this an issue?

        In order to save memory, unions allow you to use the same memory to store objects from a list of possible types as long as one object is stored at a time.

        In C and in C++ prior to C++11, unions are restricted to trivial types.

        Starting from C++11, it is possible to use unions with non-trivial types with the following limitations :

        • You have to manually handle the lifetime of the active member, using placement new and explicit object destruction.
        • You have to define special members like destructor and copy-constructor while taking into consideration the active member.

        In some cases, code that fails to perfectly follow those rules may still compile, but lead to memory corruption.

        C++17 introduced std::variant which can replace unions while removing this burden and the associated risk. As a safer and more readable alternative, they should be preferred.

        Noncompliant code example

        #include <new> // Required for placement 'new'.
        #include <string>
        #include <iostream>
        
        using namespace std;
        
        struct IntOrString {
          enum {holdsInt, holdsString} currentAlternative;
          union {
            int z;
            string s; // Noncompliant: non-trivial type in Union
          };
          IntOrString() : currentAlternative{holdsInt} {
            z = 0;
          }
          IntOrString(char const *s) : currentAlternative{holdsString} {
            new(&s) string(s);
          }
          IntOrString(IntOrString const &src) : currentAlternative{src.currentAlternative}{
              if (currentAlternative == holdsString) {
                  new(&s) string(src.s);
              }
          }
          IntOrString &operator=(IntOrString &&) = delete;
          ~IntOrString() {
              if (currentAlternative == holdsString) {
                  s.~string();
              }
          }
        };
        
        void stringize(IntOrString &ios) {
            if (ios.currentAlternative == IntOrString::holdsString) {
                return;
            }
            new (&ios.s) string(std::to_string(ios.z));
        }
        
        int main() {
          IntOrString ios;
          auto copy = ios;
          ios.z = 12;
          stringize(ios);
          std::cout<< ios.s << "\n";
        }
        

        Compliant solution

        #include <variant>
        #include <iostream>
        #include <string>
        
        using namespace std;
        using IntOrString = variant<int, string>;
        
        void stringize(IntOrString &ios) {
            if(auto i = get_if<int>(&ios)) {
                ios = to_string(*i);
            }
        }
        int main() {
            IntOrString ios = 12;
            auto copy = ios;
            stringize(ios);
            cout << std::get<string>(ios) << '\n';
        }
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use