SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C++

C++ static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C++ code

  • All rules 674
  • Vulnerability13
  • Bug139
  • Security Hotspot19
  • Code Smell503

  • Quick Fix 91
Filtered: 62 rules found
since-c++11
    Impact
      Clean code attribute
        1. A single L in a literal suffix should only be used for long values

           Code Smell
        2. "static_assert" should be preferred to assert when the argument is a compile-time constant

           Code Smell
        3. Perfect forwarding constructors should be constrained

           Bug
        4. rvalue reference members should not be copied accidentally

           Code Smell
        5. "auto" should be used to store a result of functions that conventionally return an iterator or a range

           Code Smell
        6. "emplace" should be prefered over "insert" with "std::set" and "std::unordered_set"

           Code Smell
        7. Unnecessary expensive copy should be avoided when using auto as a placeholder type

           Code Smell
        8. The right template argument should be specified for std::forward

           Code Smell
        9. Exception specifications should be treated as part of the type

           Code Smell
        10. Free functions should be preferred to member functions when accessing a container in a generic context

           Code Smell
        11. Objects should not be created solely to be passed as arguments to functions that perform delegated object creation

           Code Smell
        12. Emplacement should be preferred when insertion creates a temporary with sequence containers

           Code Smell
        13. "bind" should not be used

           Code Smell
        14. "std::initializer_list" constructor should not overlap with other constructors

           Code Smell
        15. Threads should not be detached

           Code Smell
        16. "shared_ptr" should not be taken by rvalue reference

           Code Smell
        17. Inheriting constructors should be used

           Code Smell
        18. "make_unique" and "make_shared" should be used to construct "unique_ptr" and "shared_ptr"

           Code Smell
        19. "auto" should be used to avoid repetition of types

           Code Smell
        20. Multiple mutexes should not be acquired with individual locks

           Code Smell
        21. Pointers or references obtained from aliased smart pointers should not be used as function parameters

           Code Smell
        22. "try_lock", "lock" and "unlock" should not be directly used for mutexes

           Code Smell
        23. Function parameters that are rvalue references should be moved

           Code Smell
        24. Capture by reference in lambdas used locally

           Code Smell
        25. "Forwarding references" parameters should be used only to forward parameters

           Code Smell
        26. "std::move" and "std::forward" should not be confused

           Bug
        27. "using" should be preferred for type aliasing

           Code Smell
        28. "std::move" should only be used where moving can happen

           Code Smell
        29. Functions that throw exceptions should not be used as hash functions

           Code Smell
        30. "constexpr" functions should not be declared "inline"

           Code Smell
        31. A call to "wait()" on a "std::condition_variable" should have a condition

           Bug
        32. "std::move" should not inhibit optimizations

           Code Smell
        33. Moved-from objects should not be relied upon

           Code Smell
        34. Functions which do not return should be declared as "noreturn"

           Code Smell
        35. Memory should not be managed manually

           Code Smell
        36. Facilities in <random> should be used instead of "srand", "rand" and "random_shuffle"

           Code Smell
        37. Lambdas that capture "this" should capture everything explicitly

           Code Smell
        38. Move and swap operations should be "noexcept"

           Code Smell
        39. Function parameters should not be of type "std::unique_ptr<T> const &"

           Code Smell
        40. "std::auto_ptr" should not be used

           Bug
        41. "nullptr" should be used to denote the null pointer

           Code Smell
        42. "auto" should not be used to deduce raw pointers

           Code Smell
        43. Local variables and member data should not be volatile

           Code Smell
        44. Destructors should be "noexcept"

           Bug
        45. Scoped enumerations should be used

           Code Smell
        46. "const" and "volatile" should not be used in "enum" declarations

           Code Smell
        47. Raw string literals should be used

           Code Smell
        48. "static" should not be used in unnamed namespaces

           Code Smell
        49. Default capture should not be used

           Code Smell
        50. "final" classes should not have "virtual" functions

           Code Smell
        51. Redundant lambda return types should be omitted

           Code Smell
        52. Special member function should not be defined unless a non standard behavior is required

           Code Smell
        53. "override" or "final" should be used instead of "virtual"

           Code Smell
        54. "final" classes should not have "protected" members

           Code Smell
        55. "final" should not be used redundantly

           Code Smell
        56. Lambdas should not be used

           Code Smell
        57. Lambdas should not have too many lines

           Code Smell
        58. A non-"transient lambda" shall not implicitly capture "this"

           Code Smell
        59. "Unscoped enumerations" should not be declared

           Code Smell
        60. "Forwarding references" and "std::forward" shall be used together

           Code Smell
        61. Variables should be captured explicitly in a non-"transient lambda"

           Code Smell
        62. "nullptr" shall be the only form of the "null-pointer-constant"

           Code Smell

        "std::move" should not inhibit optimizations

        intentionality - efficient
        maintainability
        Code Smell
        • cppcoreguidelines
        • performance
        • since-c++11

        This rule reports an issue when the use of std::move prevents the copy elision optimizations from happening.

        Why is this an issue?

        How can I fix it?

        More Info

        Usually, when copying an object, the source object is unchanged, meaning all resources owned by the source objects must be duplicated during the copy operation. If the source object is no longer used, this duplication is inefficient. Since C++11, a move semantic mechanism has been added to detect such cases and replace the expensive copy with a much cheaper move operation that will transfer resources.

        The cornerstone of move semantics is detecting during a "copy" whether the source object will be reused or not. This can be done explicitly by the user, by invoking std::move (or different casts to rvalue) on the object. In such case the user promises to the compiler that they won’t care for the object’s current value any longer. In addition, the compiler will implicitly use a move operation or skip copying the object in some situations.

        One case of optimization is that the copy will be elided or automatically turned into a move operation when a temporary object of type T:

        • is used to initialize a parameter or variable of type T or const T
        • is returned from the function that declares T or const T as return type
        class A {/* ... */};
        A create();
        
        void asParam(A a);
        
        A returnedFromFunc() {
          // For all examples below, the object will not be copied.
          // Either no copy or move will be performed (as guaranteed optimization since C++17)
          // or a move operation will be used.
          A a = create();
          asParam(createA());
          return A();
        }
        

        Calling std::move on such an object is not only unnecessary but will also prevent the compiler from performing copy elision, and the rule raises issues in that case.

        class A {/* ... */};
        A create();
        
        void asParam(A a);
        
        A returnedFromFunc() {
          // Move operations need to be performed, and cannot be elided.
          A a = std::move(create());     // Noncompliant
          asParam(std::move(createA())); // Noncompliant
          return std::move(A());         // Noncompliant
        }
        

        Another case of optimization is that under certain conditions, the local variable or function parameter is implicitly moved if it is directly returned (return x) from the function.

        In particular, when a variable of type T is returned directly from the function that declares T or const T as a return type:

        class A {/* ... */};
        
        A returnedLocalVar() {
          A a = create();
          // Variable a is automatically moved here
          return a;
        }
        

        These conditions overlap with the conditions under which copy elision optimization, referred to as Named Return Value Optimization (NRVO) can be performed by the compiler. When this optimization is applied the local variable is returned without any copy or move operation being performed.

        In this case, adding std::move to the return statement will inhibit this optimization, and the rule raises an issue.

        class A {/* ... */};
        
        A returnedLocalVar() {
          A a = create();
          // Variable a is moved, but NRVO cannot be performed
          return std::move(a); // Noncompliant
        }
        

        Why is the issue raised if my class does not have a move constructor?

        A move itself is not performing any object operation, and casting a source to rvalue. This leads to the constructor and assignment operator that accepts rvalue reference as a parameter - also referred to as move constructor and move assignment - to be selected by the overload resolution. However, when the class does not provide such a constructor, a copy constructor/assignment will be invoked respectively.

        Such invocation of copy constructor may still be eliminated by copy elision optimizations, and thus redundant std::move calls, that inhibit such optimization, have a performance impact in such situations.

        class OnlyCopyable {
          OnlyCopyable(OnlyCopyable const&);
          /* No move constructor */
        };
        OnlyCopyable create();
        
        void test() {
          // Forces a move operation, that invokes copy constructor
          OnlyCopyable c1 = std::move(create()); // Noncompliant
          // Copy elision eliminates invocation of the copy constructor
          OnlyCopyable c2 = create(); // Compliant
        }
        

        Why is an issue raised when passing an argument to a reference parameter?

        The copy elision optimization happens only if a new value is produced from the source, not if the parameter is a reference to the same type:

        void process(A&& sink);
        
        void passArgument() {
          // No move operation is triggered, as the parameter is a reference to A
          process(std::move(create())); // Noncompliant
          process(create());            // Compliant
        }
        

        Such redundant calls to std::move are not inhibiting optimization at this point. However, when the process function is modified to accept A by value, it will prevent the compiler from eliminating the move operation altogether. To fully benefit from the performance impact of this change, the maintainers would need to review and update all call sites and process functions, reducing the maintainability of the code.

        Moreover, if the parameter is a reference to a type to which the argument is converted, then copy elision may still happen when calling the converting constructor.

        class B {
          // Converting constructor takes object B by value
          B(A a);
        };
        void processB(B&& sink);
        
        void passArgument() {
          processB(create());            // Compliant
          processB(std::move(create())); // Noncompliant, inhibits copy elision when initializing constructor parameter
          // This call is equivalent to:
          processB(B(std::move(create()))); // Noncompliant, inhibits copy elision when initializing constructor parameter
        }
        

        Why issues are not raised for all redundant moves?

        The requirements from performing an implicit move were relaxed in C++20 and C++23 standards, with some of them being applied retroactively. As a consequence depending on the standard and compiler versions, a call to std::move may or may not be redundant in the return statement, and thus required for the code to be portable accross compilers.

          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use