SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C++

C++ static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C++ code

  • All rules 798
  • Vulnerability14
  • Bug173
  • Security Hotspot19
  • Code Smell592

  • Quick Fix 99
Filtered: 72 rules found
since-c++11
    Impact
      Clean code attribute
        1. A single L in a literal suffix should only be used for long values

           Code Smell
        2. "static_assert" should be preferred to assert when the argument is a compile-time constant

           Code Smell
        3. Perfect forwarding constructors should be constrained

           Bug
        4. rvalue reference members should not be copied accidentally

           Code Smell
        5. "auto" should be used to store a result of functions that conventionally return an iterator or a range

           Code Smell
        6. "emplace" should be prefered over "insert" with "std::set" and "std::unordered_set"

           Code Smell
        7. Unnecessary expensive copy should be avoided when using auto as a placeholder type

           Code Smell
        8. The right template argument should be specified for std::forward

           Code Smell
        9. Exception specifications should be treated as part of the type

           Code Smell
        10. Free functions should be preferred to member functions when accessing a container in a generic context

           Code Smell
        11. Objects should not be created solely to be passed as arguments to functions that perform delegated object creation

           Code Smell
        12. Emplacement should be preferred when insertion creates a temporary with sequence containers

           Code Smell
        13. "bind" should not be used

           Code Smell
        14. "std::initializer_list" constructor should not overlap with other constructors

           Code Smell
        15. Threads should not be detached

           Code Smell
        16. "shared_ptr" should not be taken by rvalue reference

           Code Smell
        17. Inheriting constructors should be used

           Code Smell
        18. "make_unique" and "make_shared" should be used to construct "unique_ptr" and "shared_ptr"

           Code Smell
        19. "auto" should be used to avoid repetition of types

           Code Smell
        20. Multiple mutexes should not be acquired with individual locks

           Code Smell
        21. Pointers or references obtained from aliased smart pointers should not be used as function parameters

           Code Smell
        22. "try_lock", "lock" and "unlock" should not be directly used for mutexes

           Code Smell
        23. Function parameters that are rvalue references should be moved

           Code Smell
        24. Capture by reference in lambdas used locally

           Code Smell
        25. "Forwarding references" parameters should be used only to forward parameters

           Code Smell
        26. "std::move" and "std::forward" should not be confused

           Bug
        27. "using" should be preferred for type aliasing

           Code Smell
        28. "std::move" should only be used where moving can happen

           Code Smell
        29. Functions that throw exceptions should not be used as hash functions

           Code Smell
        30. "constexpr" functions should not be declared "inline"

           Code Smell
        31. A call to "wait()" on a "std::condition_variable" should have a condition

           Bug
        32. "std::move" should not inhibit optimizations

           Code Smell
        33. Moved-from objects should not be relied upon

           Code Smell
        34. Functions which do not return should be declared as "noreturn"

           Code Smell
        35. Memory should not be managed manually

           Code Smell
        36. Facilities in <random> should be used instead of "srand", "rand" and "random_shuffle"

           Code Smell
        37. Lambdas that capture "this" should capture everything explicitly

           Code Smell
        38. Move and swap operations should be "noexcept"

           Code Smell
        39. Function parameters should not be of type "std::unique_ptr<T> const &"

           Code Smell
        40. "std::auto_ptr" should not be used

           Bug
        41. "nullptr" should be used to denote the null pointer

           Code Smell
        42. "auto" should not be used to deduce raw pointers

           Code Smell
        43. Local variables should not be volatile

           Code Smell
        44. Destructors should be "noexcept"

           Bug
        45. Scoped enumerations should be used

           Code Smell
        46. "const" and "volatile" should not be used in "enum" declarations

           Code Smell
        47. Raw string literals should be used

           Code Smell
        48. "static" should not be used in unnamed namespaces

           Code Smell
        49. Default capture should not be used

           Code Smell
        50. "final" classes should not have "virtual" functions

           Code Smell
        51. Redundant lambda return types should be omitted

           Code Smell
        52. Special member function should not be defined unless a non standard behavior is required

           Code Smell
        53. "override" or "final" should be used instead of "virtual"

           Code Smell
        54. "final" classes should not have "protected" members

           Code Smell
        55. "final" should not be used redundantly

           Code Smell
        56. Lambdas should not be used

           Code Smell
        57. Lambdas should not have too many lines

           Code Smell
        58. A non-"transient lambda" shall not implicitly capture "this"

           Code Smell
        59. A "for-range-initializer" shall contain at most one function call

           Bug
        60. "User-provided" copy and move member functions of a class should have appropriate signatures

           Code Smell
        61. "Special member functions" shall be provided appropriately

           Code Smell
        62. Member functions returning references to their object should be "ref-qualified" appropriately

           Code Smell
        63. "User-declared" member functions shall use the "virtual", "override" and "final" specifiers appropriately

           Code Smell
        64. A class shall only define an "initializer-list constructor" when it is the only constructor

           Code Smell
        65. "Unscoped enumerations" should not be declared

           Code Smell
        66. The raw pointer constructors of "std::shared_ptr" and "std::unique_ptr" should not be used

           Code Smell
        67. "Forwarding references" and "std::forward" shall be used together

           Code Smell
        68. The argument to "std::move" shall be a non-const "lvalue"

           Code Smell
        69. Dynamic memory shall be managed automatically

           Code Smell
        70. The "assert" macro shall not be used with a "constant-expression"

           Code Smell
        71. Variables should be captured explicitly in a non-"transient lambda"

           Code Smell
        72. "nullptr" shall be the only form of the "null-pointer-constant"

           Code Smell

        "Special member functions" shall be provided appropriately

        intentionality - complete
        maintainability
        Code Smell
        • pitfall
        • since-c++11
        • misra-c++2023
        • misra-required

        Why is this an issue?

        More Info

        This rule is part of MISRA C++:2023.

        Usage of this content is governed by Sonar’s terms and conditions. Redistribution is prohibited.

        Rule 15.0.1 - Special member functions shall be provided appropriately

        Category: Required

        Analysis: Decidable, Single Translation Unit

        Amplification

        For the purposes of this rule, a special member function is said to be customized if it is user-provided and not defaulted.

        All out-of-class definitions of the destructor, copy operations, and move operations for a class shall be placed in a single file.

        In addition, a class shall satisfy all of the requirements defined within this rule that apply to it. For instance, a class that is used as a base class and that has a customized destructor shall comply with the requirements within all of the following requirement sections.

        Heading: Requirements for all classes on copyability and movability

        A class T is copy-constructible if the expression std::is_copy_constructible_v< T > is true, and similarly for move-constructible, move-assignable, and copy-assignable.

        A class shall belong to exactly one of the following categories (other combinations are not permitted):

        • Unmovable — it is not copy-constructible, not move-constructible, not copy-assignable and not move-assignable; or
        • Move-only — it is move-constructible (and optionally move-assignable) but neither copy-constructible nor copy-assignable; or
        • Copy-enabled — it is copy-constructible and move-constructible and can optionally also be both copy-assignable and move-assignable.

        Category

        Move constructible

        Move assignable

        Copy constructible

        Copy assignable

        Unmovable

        No

        No

        No

        No

        Move-only

        Yes

        No

        No

        No

        :::

        Yes

        Yes

        No

        No

        Copy-enabled

        Yes

        No

        Yes

        No

        :::

        Yes

        Yes

        Yes

        Yes

        Heading: Requirements in the presence of customized copy or move operations

        If a class has customized copy or move operations, it shall have a customized destructor.

        Heading: Requirements in the presence of customized destructors

        The definition of any customized destructor shall contain at least one statement that is neither a compound statement nor a null statement. A class with such a destructor is regarded by this rule as managing a resource.

        Additionally:

        • If the class is unmovable, it is defined to be a scoped manager [1].
        • If the class is move-only, it shall have a customized move constructor. If it is move-assignable, it shall also have a customized move assignment operator. Such a class is defined to be a unique manager [2].
        • If the class is copy-enabled, it shall have a customized copy constructor and its move constructor shall either be customized or not declared. If it is copy-assignable, it shall also have a customized copy-assignment operator and the move operations shall either both be customized or both not be declared. Such a class is defined to be a general manager [3].

        Heading: Requirements in the presence of inheritance

        A class that is used as a public base class shall either:

        • Be an unmovable class that has a (possibly inherited) public virtual destructor; or
        • Have a protected non-virtual destructor.

        Note: these destructors shall either be defined as = default or customized (and non-empty).

        Rationale

        Language rules determining which user-declared special member functions suppress which of the compiler-provided functions are subtle and, for legacy reasons, the combinations produced may be semantically unsound (see [depr.impldec] in the C++ Standard).

        This rule takes advantage of reasonable language-provided defaults and, in particular, avoids the need to explicitly implement these defaults within the code; code that is, or attempts to be, equivalent to the compiler-provided functions is superfluous and may have subtle behavioural differences.

        More specifically, application of the "Rule of Zero" in class definitions is encouraged — i.e. when a class does not declare any of the move constructor, copy constructor, move-assignment operator, copy-assignment operator, or destructor special member functions. A class following the "Rule of Zero" can be unmovable, move-only or copy-enabled, depending on the properties of the class’s members and base classes.

        The requirements on copyability and movability enforce the use of semantically sound combinations of the special member functions. In particular, they ensure that copy-constructible types are always move-constructible.

        The requirements on classes with customized destructors cover the cases where resource management is involved and ensure that, when a class directly handles a resource, customized code will be called when an instance of the class is copied, moved or destroyed.

        The requirements on base classes reduce the risk of slicing and deleting a derived class instance through a base class pointer, when the base class does not have a virtual destructor:

        • Compliance with requirement 1 ensures that these risks are completely prevented.
        • Compliance with requirement 2 ensures that these risks are prevented for code that does not have privileged access to the base class.

        Compliance with this rule addresses the vulnerabilities covered by the "Rule of Zero", the "Rule of Five" and similar rules in other C++ guidelines. It also covers the vulnerabilities identified within the pre-C++11 "Rule of Three" — see the requirements for general manager [3] (above).

        Exception

        An aggregate, which cannot have a user-declared destructor, may be used as a public base class — this allows empty base class optimization for mix-in and tag types.

        Example

        struct MyTagClass {};       // Compliant - Rule of Zero (empty class)
        struct MyValue              // Compliant - Rule of Zero
        {
          int32_t val { 42 };
        };
        
        struct PolyBaseWrong        // Non-compliant - base class that is not an aggregate
        {                           //                 and has no virtual destructor.
          virtual void doIt();      //                 Additionally, slicing may occur.
        };
        
        struct DerivedWrong : PolyBaseWrong {};
        
        struct PolyBase             // Compliant - unmovable base class with virtual public
        {                           //             destructor
          virtual void doIt() = 0;
          virtual ~PolyBase() = default;
        
          PolyBase & operator=( PolyBase && ) = delete;   // This makes the class unmovable
        };
        
        struct Derived : PolyBase
        {
          // Class definition
        };
        
        struct NonEmptyDestructor   // Non-compliant - copy-enabled class with a customized
                                    //                 destructor but non-customized
        {                           //                 copy-operations
          ~NonEmptyDestructor()     // Non-compliant - customized destructor has empty body
          {
            {
              // Still empty
              ;
            }
          }
        };
        
        struct Locker               // Compliant - scoped manager
        {
          explicit Locker( std::mutex & m ) :
            m { m }
          {
            m.lock();
          }
        
          ~Locker()
          {
            m.unlock();
          }
        
          Locker & operator=( Locker && ) = delete;       // This makes the class unmovable
        
        private:
          std::mutex & m;
        };
        
        struct NonMovable           // Non-compliant - copy-constructible, but not
        {                           //                 move-constructible
          NonMovable( NonMovable const &  );
          NonMovable( NonMovable       && ) = delete;
        };
        
        struct Aggregate { };
        
        struct Child : Aggregate    // Compliant by exception - base class without
        {                           //                          destructor is an aggregate
        };
        

        Glossary

        [1] Scoped manager

        A manager class [4], as defined in M23_372: MISRA C++ 2023 Rule 15.0.1.

        [2] Unique manager

        A manager class [4], as defined in M23_372: MISRA C++ 2023 Rule 15.0.1.

        [3] General manager

        A manager class [4], as defined in M23_372: MISRA C++ 2023 Rule 15.0.1.

        [4] Manager class

        A class that is either a scoped manager [1], a unique manager [2], or a general manager [3] as defined in M23_372: MISRA C++ 2023 Rule 15.0.1.

        Copyright The MISRA Consortium Limited © 2023

          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI

        © 2025 SonarSource Sàrl. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use