SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C++

C++ static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C++ code

  • All rules 674
  • Vulnerability13
  • Bug139
  • Security Hotspot19
  • Code Smell503

  • Quick Fix 91
Filtered: 24 rules found
performance
    Impact
      Clean code attribute
        1. "std::format" should be used instead of standard output manipulators

           Code Smell
        2. Concatenated "std::format" outputs should be replaced by a single invocation

           Code Smell
        3. Use conditional suspension to resume current coroutine

           Code Smell
        4. rvalue reference members should not be copied accidentally

           Code Smell
        5. "std::string_view" and "std::span" parameters should be directly constructed from sequences

           Code Smell
        6. Empty class members should be marked as "[[no_unique_address]]"

           Code Smell
        7. Transparent function objects should be used with associative "std::string" containers

           Code Smell
        8. "emplace" should be prefered over "insert" with "std::set" and "std::unordered_set"

           Code Smell
        9. Unnecessary expensive copy should be avoided when using auto as a placeholder type

           Code Smell
        10. "try_emplace" should be used with "std::map" and "std::unordered_map"

           Code Smell
        11. Heterogeneous sorted containers should only be used with types that support heterogeneous comparison

           Bug
        12. Objects should not be created solely to be passed as arguments to functions that perform delegated object creation

           Code Smell
        13. "std::filesystem::path" should be used to represent a file path

           Code Smell
        14. Emplacement should be preferred when insertion creates a temporary with sequence containers

           Code Smell
        15. Return type of functions shouldn't be const qualified value

           Code Smell
        16. "std::endl" should not be used

           Code Smell
        17. Capture by reference in lambdas used locally

           Code Smell
        18. "std::move" should not inhibit optimizations

           Code Smell
        19. Template parameters should be preferred to "std::function" when configuring behavior at compile time

           Code Smell
        20. Special member function should not be defined unless a non standard behavior is required

           Code Smell
        21. Member data should be initialized in-class or in a constructor initialization list

           Code Smell
        22. Bit fields should not be used

           Code Smell
        23. The prefix increment/decrement form should be used

           Code Smell
        24. Pass by reference to const should be used for large input parameters

           Code Smell

        "std::move" should not inhibit optimizations

        intentionality - efficient
        maintainability
        Code Smell
        • cppcoreguidelines
        • performance
        • since-c++11

        This rule reports an issue when the use of std::move prevents the copy elision optimizations from happening.

        Why is this an issue?

        How can I fix it?

        More Info

        Usually, when copying an object, the source object is unchanged, meaning all resources owned by the source objects must be duplicated during the copy operation. If the source object is no longer used, this duplication is inefficient. Since C++11, a move semantic mechanism has been added to detect such cases and replace the expensive copy with a much cheaper move operation that will transfer resources.

        The cornerstone of move semantics is detecting during a "copy" whether the source object will be reused or not. This can be done explicitly by the user, by invoking std::move (or different casts to rvalue) on the object. In such case the user promises to the compiler that they won’t care for the object’s current value any longer. In addition, the compiler will implicitly use a move operation or skip copying the object in some situations.

        One case of optimization is that the copy will be elided or automatically turned into a move operation when a temporary object of type T:

        • is used to initialize a parameter or variable of type T or const T
        • is returned from the function that declares T or const T as return type
        class A {/* ... */};
        A create();
        
        void asParam(A a);
        
        A returnedFromFunc() {
          // For all examples below, the object will not be copied.
          // Either no copy or move will be performed (as guaranteed optimization since C++17)
          // or a move operation will be used.
          A a = create();
          asParam(createA());
          return A();
        }
        

        Calling std::move on such an object is not only unnecessary but will also prevent the compiler from performing copy elision, and the rule raises issues in that case.

        class A {/* ... */};
        A create();
        
        void asParam(A a);
        
        A returnedFromFunc() {
          // Move operations need to be performed, and cannot be elided.
          A a = std::move(create());     // Noncompliant
          asParam(std::move(createA())); // Noncompliant
          return std::move(A());         // Noncompliant
        }
        

        Another case of optimization is that under certain conditions, the local variable or function parameter is implicitly moved if it is directly returned (return x) from the function.

        In particular, when a variable of type T is returned directly from the function that declares T or const T as a return type:

        class A {/* ... */};
        
        A returnedLocalVar() {
          A a = create();
          // Variable a is automatically moved here
          return a;
        }
        

        These conditions overlap with the conditions under which copy elision optimization, referred to as Named Return Value Optimization (NRVO) can be performed by the compiler. When this optimization is applied the local variable is returned without any copy or move operation being performed.

        In this case, adding std::move to the return statement will inhibit this optimization, and the rule raises an issue.

        class A {/* ... */};
        
        A returnedLocalVar() {
          A a = create();
          // Variable a is moved, but NRVO cannot be performed
          return std::move(a); // Noncompliant
        }
        

        Why is the issue raised if my class does not have a move constructor?

        A move itself is not performing any object operation, and casting a source to rvalue. This leads to the constructor and assignment operator that accepts rvalue reference as a parameter - also referred to as move constructor and move assignment - to be selected by the overload resolution. However, when the class does not provide such a constructor, a copy constructor/assignment will be invoked respectively.

        Such invocation of copy constructor may still be eliminated by copy elision optimizations, and thus redundant std::move calls, that inhibit such optimization, have a performance impact in such situations.

        class OnlyCopyable {
          OnlyCopyable(OnlyCopyable const&);
          /* No move constructor */
        };
        OnlyCopyable create();
        
        void test() {
          // Forces a move operation, that invokes copy constructor
          OnlyCopyable c1 = std::move(create()); // Noncompliant
          // Copy elision eliminates invocation of the copy constructor
          OnlyCopyable c2 = create(); // Compliant
        }
        

        Why is an issue raised when passing an argument to a reference parameter?

        The copy elision optimization happens only if a new value is produced from the source, not if the parameter is a reference to the same type:

        void process(A&& sink);
        
        void passArgument() {
          // No move operation is triggered, as the parameter is a reference to A
          process(std::move(create())); // Noncompliant
          process(create());            // Compliant
        }
        

        Such redundant calls to std::move are not inhibiting optimization at this point. However, when the process function is modified to accept A by value, it will prevent the compiler from eliminating the move operation altogether. To fully benefit from the performance impact of this change, the maintainers would need to review and update all call sites and process functions, reducing the maintainability of the code.

        Moreover, if the parameter is a reference to a type to which the argument is converted, then copy elision may still happen when calling the converting constructor.

        class B {
          // Converting constructor takes object B by value
          B(A a);
        };
        void processB(B&& sink);
        
        void passArgument() {
          processB(create());            // Compliant
          processB(std::move(create())); // Noncompliant, inhibits copy elision when initializing constructor parameter
          // This call is equivalent to:
          processB(B(std::move(create()))); // Noncompliant, inhibits copy elision when initializing constructor parameter
        }
        

        Why issues are not raised for all redundant moves?

        The requirements from performing an implicit move were relaxed in C++20 and C++23 standards, with some of them being applied retroactively. As a consequence depending on the standard and compiler versions, a call to std::move may or may not be redundant in the return statement, and thus required for the code to be portable accross compilers.

          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use