SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C++

C++ static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C++ code

  • All rules 674
  • Vulnerability13
  • Bug139
  • Security Hotspot19
  • Code Smell503

  • Quick Fix 91
Filtered: 55 rules found
bad-practice
    Impact
      Clean code attribute
        1. Pointer and reference parameters should be "const" if the corresponding object is not modified

           Code Smell
        2. Reserved identifiers should not be defined or declared

           Code Smell
        3. Only standard forms of the "defined" directive should be used

           Code Smell
        4. Function-like macros should not be used

           Code Smell
        5. Recursion should not be used

           Code Smell
        6. "continue" should not be used

           Code Smell
        7. Bitwise operators should not be applied to signed operands

           Bug
        8. Escape sequences should use the delimited form (\u{}, \o{}, \x{})

           Code Smell
        9. Names of well-known C standard library macros and functions should not be used as identifiers

           Code Smell
        10. C++ formatting functions should be used instead of C printf-like functions

           Code Smell
        11. Use "std::format" rather than "std::vformat" when the format string is known at compile time

           Code Smell
        12. Template should not be constrained with ad-hoc requires-expression

           Code Smell
        13. Use type-erased "coroutine_handle" when applicable

           Code Smell
        14. Well-defined type-punning method should be used instead of a union-based one

           Bug
        15. "std::cmp_*" functions should be used to compare unsigned values with negative values

           Bug
        16. STL constrained algorithms with range parameter should be used when iterating over the entire range

           Code Smell
        17. "std::cmp_*" functions should be used to compare signed and unsigned values

           Code Smell
        18. "std::bit_cast" should be used to reinterpret binary representation instead of "std::memcpy"

           Code Smell
        19. "[[likely]]" and "[[unlikely]]" should be used instead of compiler built-ins

           Code Smell
        20. "starts_with" and "ends_with" should be used for prefix and postfix checks

           Code Smell
        21. "std::jthread" should be used instead of "std::thread"

           Code Smell
        22. "nodiscard" attributes on functions should include explanations

           Code Smell
        23. "std::endl" should not be used

           Code Smell
        24. C-style array should not be used

           Code Smell
        25. Macros should not be used as replacements for "typedef" and "using"

           Code Smell
        26. Integer literals should not be cast to bool

           Code Smell
        27. Multiple mutexes should not be acquired with individual locks

           Code Smell
        28. "try_lock", "lock" and "unlock" should not be directly used for mutexes

           Code Smell
        29. A single statement should not have more than one resource allocation

           Code Smell
        30. Function parameters that are rvalue references should be moved

           Code Smell
        31. Capture by reference in lambdas used locally

           Code Smell
        32. Size of bit fields should not exceed the size of their types

           Code Smell
        33. Functions should not have more than one argument of type "bool"

           Code Smell
        34. Non-const global variables should not be used

           Code Smell
        35. The order for arguments of the same type in a function call should be obvious

           Code Smell
        36. "std::move" should only be used where moving can happen

           Code Smell
        37. Classes should not contain both public and private data members

           Code Smell
        38. Pointer and reference local variables should be "const" if the corresponding object is not modified

           Code Smell
        39. Argument of "printf" should be a format string

           Code Smell
        40. Template parameters should be preferred to "std::function" when configuring behavior at compile time

           Code Smell
        41. Macros should not be used to define constants

           Code Smell
        42. Memory should not be managed manually

           Code Smell
        43. Function parameters should not be of type "std::unique_ptr<T> const &"

           Code Smell
        44. "nullptr" should be used to denote the null pointer

           Code Smell
        45. Exceptions should not be thrown in "noexcept" functions

           Code Smell
        46. Redundant lambda return types should be omitted

           Code Smell
        47. Member variables should be initialized

           Bug
        48. Loops with at most one iteration should be refactored

           Bug
        49. "if" statements should be preferred over "switch" when simpler

           Code Smell
        50. Track uses of "NOSONAR" comments

           Code Smell
        51. Generic exceptions should not be caught

           Code Smell
        52. Deprecated attributes should include explanations

           Code Smell
        53. Standard outputs should not be used directly to log anything

           Code Smell
        54. Classes should not be inherited virtually

           Code Smell
        55. The "union" keyword shall not be used

           Code Smell

        Template should not be constrained with ad-hoc requires-expression

        intentionality - clear
        maintainability
        Code Smell
        • bad-practice
        • confusing
        • since-c++20

        Why is this an issue?

        Since C++20, it is possible to add a requires-clause to a template as a way to express requirements (constraints) on the template arguments. This construct is versatile and allows any expression that evaluates to either true or false at compile time to be used. One of these expressions is the requires-expression, which can be used to express required operations on types:

        template<typename M>
          requires requires(M a, M b) {
            { a + b };
            { a * b };
          }
        M fma(M a, M b, M c) {
          return a + (b * c);
        }
        

        While the use of an ad-hoc requires-expression provides a way to quickly constrain a template, it limits the readability of the code: While it conveys the required syntax requirements, it fails to express the semantics associated with the operations. For instance, the above template expects that + and * perform mathematical additions and multiplications, not a concatenation of strings.

        Using a concept with a well-chosen name solves this issue and meaningful concepts that are reused in different parts of the codebase increase the level of abstraction of the code: You don’t need to check individual operations, you just need to know that your type is integral.

        Moreover, one interesting feature of concepts is called subsumption. It means that when a function overload is constrained with a list of concepts, and another overload is constrained with the same concepts plus additional constraints, then the second function is considered as more constrained than the first one, and will be selected by overload resolution if the concepts are satisfied.

        This feature only works with concepts: a requires-expression is never considered to be more constrained than another one, even if both contain identical subexpressions. For instance, the following overloads of rotate are ambiguous for any iterator that is at least bidirectional, as constraints for both of them are satisfied:

        template<typename ForwardIt>
          requires requires(ForwardIt it) {
            /* dereference and others */
            ++it;
          }
        ForwardIt rotate(ForwardIt first, ForwardIt mid, ForwardIt last);
        
        template<typename BidirectionalIt>
          requires requires(BidirectionalIt it) {
            /* dereference and others */
            ++it;
            --it;
          }
        BidirectionalIt rotate(BidirectionalIt first, BidirectionalIt mid,  BidirectionalIt last);
        

        This rule raises an issue for any use of an ad-hoc requires-expression in the requirements of template functions, classes, or variables.

        Noncompliant code example

        template<typename M>
          requires requires(M a, M b) { // noncompliant
            { a + b };
            { a * b };
          }
        M fma(M a, M b, M c) {
          return a + (b * c);
        }
        
        template<typename ForwardIt>
          requires requires(ForwardIt it) { // noncompliant
            /* dereference and others */
            ++it;
          }
        ForwardIt rotate(ForwardIt first, ForwardIt mid, ForwardIt last);
        
        template<typename BidirectionalIt>
          requires requires(BidirectionalIt it) { // noncompliant
            /* dereference and others */
            ++it;
            --it;
          }
        BidirectionalIt rotate(BidirectionalIt first, BidirectionalIt mid, BidirectionalIt last);
        

        Compliant solution

        template<typename T>
        concept Multiplicative = requires(const T a, const T b) {
          { a + b };
          { a * b };
        }
        
        template<Multiplicative M>
        M fma(M a, M b, M c) {
          return a + (b * c);
        }
        
        template<class ForwardIt>
          requires std::forward_iterator<ForwardIt>
        ForwardIt rotate(ForwardIt first, ForwardIt mid, ForwardIt last);
        
        // std::bidirectional_iterator subsumes std::forward_iterator, as it is defined as:
        // template<class I>
        //   concept bidirectional_iterator = forward_iterator<I> && additional requirements;
        template<class BidirectionalIt>
          requires std::bidirectional_iterator<BidirectionalIt>
        BidirectionalIt rotate(BidirectionalIt first, BidirectionalIt mid, BidirectionalIt last);
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.8

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use