SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C++

C++ static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C++ code

  • All rules 798
  • Vulnerability14
  • Bug173
  • Security Hotspot19
  • Code Smell592

  • Quick Fix 99
Filtered: 67 rules found
bad-practice
    Impact
      Clean code attribute
        1. Pointer and reference parameters should be "const" if the corresponding object is not modified

           Code Smell
        2. Reserved identifiers should not be defined or declared

           Code Smell
        3. Only standard forms of the "defined" directive should be used

           Code Smell
        4. Function-like macros should not be used

           Code Smell
        5. Recursion should not be used

           Code Smell
        6. "continue" should not be used

           Code Smell
        7. Bitwise operators should not be applied to signed operands

           Bug
        8. Escape sequences should use the delimited form (\u{}, \o{}, \x{})

           Code Smell
        9. Names of well-known C standard library macros and functions should not be used as identifiers

           Code Smell
        10. C++ formatting functions should be used instead of C printf-like functions

           Code Smell
        11. Use "std::format" rather than "std::vformat" when the format string is known at compile time

           Code Smell
        12. Template should not be constrained with ad-hoc requires-expression

           Code Smell
        13. Use type-erased "coroutine_handle" when applicable

           Code Smell
        14. Well-defined type-punning method should be used instead of a union-based one

           Bug
        15. "std::cmp_*" functions should be used to compare unsigned values with negative values

           Bug
        16. STL constrained algorithms with range parameter should be used when iterating over the entire range

           Code Smell
        17. "std::cmp_*" functions should be used to compare signed and unsigned values

           Code Smell
        18. "std::bit_cast" should be used to reinterpret binary representation instead of "std::memcpy"

           Code Smell
        19. "[[likely]]" and "[[unlikely]]" should be used instead of compiler built-ins

           Code Smell
        20. "starts_with" and "ends_with" should be used for prefix and postfix checks

           Code Smell
        21. "std::jthread" should be used instead of "std::thread"

           Code Smell
        22. "nodiscard" attributes on functions should include explanations

           Code Smell
        23. "std::endl" should not be used

           Code Smell
        24. C-style array should not be used

           Code Smell
        25. Macros should not be used as replacements for "typedef" and "using"

           Code Smell
        26. Integer literals should not be cast to bool

           Code Smell
        27. Multiple mutexes should not be acquired with individual locks

           Code Smell
        28. "try_lock", "lock" and "unlock" should not be directly used for mutexes

           Code Smell
        29. A single statement should not have more than one resource allocation

           Code Smell
        30. Function parameters that are rvalue references should be moved

           Code Smell
        31. Capture by reference in lambdas used locally

           Code Smell
        32. Size of bit fields should not exceed the size of their types

           Code Smell
        33. Functions should not have more than one argument of type "bool"

           Code Smell
        34. Non-const global variables should not be used

           Code Smell
        35. The order for arguments of the same type in a function call should be obvious

           Code Smell
        36. "std::move" should only be used where moving can happen

           Code Smell
        37. Classes should not contain both public and private data members

           Code Smell
        38. Pointer and reference local variables should be "const" if the corresponding object is not modified

           Code Smell
        39. Argument of "printf" should be a format string

           Code Smell
        40. Template parameters should be preferred to "std::function" when configuring behavior at compile time

           Code Smell
        41. Macros should not be used to define constants

           Code Smell
        42. Memory should not be managed manually

           Code Smell
        43. Function parameters should not be of type "std::unique_ptr<T> const &"

           Code Smell
        44. "nullptr" should be used to denote the null pointer

           Code Smell
        45. Exceptions should not be thrown in "noexcept" functions

           Code Smell
        46. Redundant lambda return types should be omitted

           Code Smell
        47. Member variables should be initialized

           Bug
        48. Loops with at most one iteration should be refactored

           Bug
        49. "if" statements should be preferred over "switch" when simpler

           Code Smell
        50. Track uses of "NOSONAR" comments

           Code Smell
        51. Generic exceptions should not be caught

           Code Smell
        52. Deprecated attributes should include explanations

           Code Smell
        53. Standard outputs should not be used directly to log anything

           Code Smell
        54. The literal value zero shall be the only value assigned to "errno"

           Code Smell
        55. The operands of "bitwise operators" and "shift operators" shall be appropriate

           Bug
        56. The argument to "std::move" shall be a non-const "lvalue"

           Code Smell
        57. Deprecated features should not be used

           Code Smell
        58. The C Library input/output functions shall not be used

           Code Smell
        59. "Dynamic memory" should not be used

           Code Smell
        60. Precautions shall be taken in order to prevent the contents of a "header file" being included more than once

           Code Smell
        61. All "#else", "#elif" and "#endif" preprocessor directives shall reside in the same file as the "#if", "#ifdef" or "#ifndef" directive to which they are related

           Code Smell
        62. Non-static data members should be either all "private" or all "public"

           Code Smell
        63. Classes should not be inherited virtually

           Code Smell
        64. The "union" keyword shall not be used

           Code Smell
        65. Functions shall not call themselves, either directly or indirectly

           Code Smell
        66. The target type of a pointer or "lvalue" reference parameter should be const-qualified appropriately

           Code Smell
        67. "Trigraph-like sequences" should not be used

           Code Smell

        All "#else", "#elif" and "#endif" preprocessor directives shall reside in the same file as the "#if", "#ifdef" or "#ifndef" directive to which they are related

        intentionality - complete
        maintainability
        Code Smell
        • bad-practice
        • misra-c++2023
        • misra-required

        Why is this an issue?

        This rule is part of MISRA C++:2023.

        Usage of this content is governed by Sonar’s terms and conditions. Redistribution is prohibited.

        Rule 19.1.2 - All #else, #elif and #endif preprocessor directives shall reside in the same file as the #if, #ifdef or #ifndef directive to which they are related

        Category: Required

        Analysis: Decidable,Single Translation Unit

        Rationale

        Confusion can arise when code blocks are included or excluded by the use of conditional compilation directives which are spread over multiple files. Requiring that a #if directive be terminated within the same file reduces the visual complexity of the code and the chance that errors will be made during maintenance.

        Notes:

        • #if directives may be used within included files, provided they are terminated within the same file.
        • It is not clear from the C++ Standard whether such constructs are allowed or not. Some compilers do require that a #endif (etc.) must be in the same file as the associated #if (etc.), and all compilers tested raise an error if this is not the case. However, this requirement is not explicitly expressed in the C++ Standard, and there is a reading of the grammar that would allow it. This rule aims to prevent this construct, should any compiler actually allow it.

        Example

        // file1.c
        #ifdef A               // Compliant
        #include "file1.h"
        #endif
        // End of file1.c
        
        // file1.h
        #if 1                  // Compliant
        #endif
        // End of file1.h
        
        // file2.c
        #if 1                  // Non-compliant
        #include "file2.h"
        // End of file2.c
        
        // file2.h
        #endif
        // End of file2.h
        

        Copyright The MISRA Consortium Limited © 2023

          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI

        © 2025 SonarSource Sàrl. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use