SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C

C static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C code

  • All rules 420
  • Vulnerability14
  • Bug111
  • Security Hotspot19
  • Code Smell276

  • Quick Fix 27
Filtered: 27 rules found
unpredictable
    Impact
      Clean code attribute
        1. Arguments evaluation order should not be relied on

           Bug
        2. Keywords shall not be used as macros identifiers

           Code Smell
        3. Dereferenced null pointers should not be bound to references

           Code Smell
        4. Header guards should be followed by a matching "#define" macro

           Code Smell
        5. "memcmp" should only be called with pointers to trivially copyable types with no padding

           Bug
        6. Stack allocated memory and non-owned memory should not be freed

           Bug
        7. The "<stdlib.h>" functions "bsearch" and "qsort" should not be used

           Bug
        8. Floating-point arithmetic should be used appropriately

           Bug
        9. There shall be no occurrence of "undefined" or "critical unspecified behaviour"

           Bug
        10. An "object pointer type" shall not be cast to an integral type other than "std::uintptr_t" or "std::intptr_t"

           Code Smell
        11. The pointers returned by the C++ Standard Library functions "localeconv", "getenv", "setlocale" or "strerror" must only be used as if they have pointer to const-qualified type

           Bug
        12. Reads and writes on the same file stream shall be separated by a positioning operation

           Bug
        13. Local variables shall not have static storage duration

           Code Smell
        14. The pointer returned by the C++ Standard Library functions "asctime", "ctime", "gmtime", "localtime", "localeconv", "getenv", "setlocale" or "strerror" must not be used following a subsequent call to the same function

           Bug
        15. The "defined" preprocessor operator shall be used appropriately

           Bug
        16. The value of an object must not be read before it has been set

           Bug
        17. The built-in unary "-" operator should not be applied to an expression of unsigned type

           Bug
        18. The built-in relational operators ">", ">=", "<" and "<=" shall not be applied to objects of pointer type, except where they point to elements of the same array

           Bug
        19. Subtraction between pointers shall only be applied to pointers that address elements of the same array

           Bug
        20. Pointer arithmetic shall not form an invalid pointer

           Bug
        21. Operations on a memory location shall be sequenced appropriately

           Bug
        22. A function or object with external linkage should be "introduced" in a "header file"

           Code Smell
        23. The source code used to implement an "entity" shall appear only once

           Bug
        24. The "one-definition rule" shall not be violated

           Bug
        25. All "declarations" of a variable or function shall have the same type

           Bug
        26. A line whose first token is "#" shall be a valid preprocessing directive

           Bug
        27. An object or subobject must not be copied to an overlapping object

           Bug

        Operations on a memory location shall be sequenced appropriately

        intentionality - logical
        reliability
        Bug
        • unpredictable
        • misra-c++2023
        • misra-required

        Why is this an issue?

        More Info

        This rule is part of MISRA C++:2023.

        Usage of this content is governed by Sonar’s terms and conditions. Redistribution is prohibited.

        Rule 4.6.1 - Operations on a memory location shall be sequenced appropriately

        [intro.execution] Undefined 17

        Category: Required

        Analysis: Undecidable,System

        Amplification

        A side effect on a memory location shall not be unsequenced or indeterminately sequenced with respect to any other side effect on the same memory location, or any value computation using the value of any object in the same memory location.

        For the purposes of this rule, all volatile accesses are considered to access a single, unique memory location.

        Rationale

        Unsequenced accesses to a memory location when one of the accesses has side effects results in undefined behaviour.

        Additionally, indeterminately sequenced accesses could result in an expression yielding a different value for differing program states. This rule ensures that a program’s behaviour is independent of the evaluation order (such as the evaluation of function arguments) chosen by the compiler.

        An access to a volatile v1 may have an effect on another, seemingly unrelated, volatile v2. For this reason, this rule considers all volatile accesses as if they were to a single, unique memory location.

        Note: C++17 changed the evaluation order of several expressions from indeterminately sequenced to sequenced before, which means that code that is compliant with this rule may not work correctly with earlier versions of C++.

        Example

        char f( char & c, char a )
        {
          c = a;
        
          return c;
        }
        
        void h( char a, char b );
        
        char a;
        
        h( f( a, 'a' ), f( a, 'b' ) );   // Non-compliant - value of a could be 'a' or 'b'
        

        In the following example, i is read twice and modified twice. However, since C++17, the evaluation of the right-hand side of an assignment is sequenced before the evaluation of the left-hand side (see [expr.ass]), so all accesses to i occur in a defined order:

        a[ i++ ] = b[ i++ ];             // Compliant in C++17
        

        Even though there is no undefined behaviour in the following examples, they are non-compliant as the uses of i are indeterminately sequenced with respect to their increments:

        x = b[ i ] + i++;                // Non-compliant
        x = func( i++, i );              // Non-compliant
        

        In the following example, all accesses to volatile variables are considered to have side effects on the same memory location:

        extern volatile uint16_t v1;
        extern volatile uint16_t v2;
        
        uint16_t t = v1 + v2;            // Non-compliant - indeterminately sequenced
        
        v1 = v1 & 0x80u;                 // Compliant
        

        Copyright The MISRA Consortium Limited © 2023

          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI

        © 2025 SonarSource Sàrl. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use