SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C

C static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C code

  • All rules 420
  • Vulnerability14
  • Bug111
  • Security Hotspot19
  • Code Smell276

  • Quick Fix 27
Filtered: 27 rules found
unpredictable
    Impact
      Clean code attribute
        1. Arguments evaluation order should not be relied on

           Bug
        2. Keywords shall not be used as macros identifiers

           Code Smell
        3. Dereferenced null pointers should not be bound to references

           Code Smell
        4. Header guards should be followed by a matching "#define" macro

           Code Smell
        5. "memcmp" should only be called with pointers to trivially copyable types with no padding

           Bug
        6. Stack allocated memory and non-owned memory should not be freed

           Bug
        7. The "<stdlib.h>" functions "bsearch" and "qsort" should not be used

           Bug
        8. Floating-point arithmetic should be used appropriately

           Bug
        9. There shall be no occurrence of "undefined" or "critical unspecified behaviour"

           Bug
        10. An "object pointer type" shall not be cast to an integral type other than "std::uintptr_t" or "std::intptr_t"

           Code Smell
        11. The pointers returned by the C++ Standard Library functions "localeconv", "getenv", "setlocale" or "strerror" must only be used as if they have pointer to const-qualified type

           Bug
        12. Reads and writes on the same file stream shall be separated by a positioning operation

           Bug
        13. Local variables shall not have static storage duration

           Code Smell
        14. The pointer returned by the C++ Standard Library functions "asctime", "ctime", "gmtime", "localtime", "localeconv", "getenv", "setlocale" or "strerror" must not be used following a subsequent call to the same function

           Bug
        15. The "defined" preprocessor operator shall be used appropriately

           Bug
        16. The value of an object must not be read before it has been set

           Bug
        17. The built-in unary "-" operator should not be applied to an expression of unsigned type

           Bug
        18. The built-in relational operators ">", ">=", "<" and "<=" shall not be applied to objects of pointer type, except where they point to elements of the same array

           Bug
        19. Subtraction between pointers shall only be applied to pointers that address elements of the same array

           Bug
        20. Pointer arithmetic shall not form an invalid pointer

           Bug
        21. Operations on a memory location shall be sequenced appropriately

           Bug
        22. A function or object with external linkage should be "introduced" in a "header file"

           Code Smell
        23. The source code used to implement an "entity" shall appear only once

           Bug
        24. The "one-definition rule" shall not be violated

           Bug
        25. All "declarations" of a variable or function shall have the same type

           Bug
        26. A line whose first token is "#" shall be a valid preprocessing directive

           Bug
        27. An object or subobject must not be copied to an overlapping object

           Bug

        The source code used to implement an "entity" shall appear only once

        intentionality - logical
        reliability
        Bug
        • unpredictable
        • misra-c++2023
        • misra-required

        Why is this an issue?

        This rule is part of MISRA C++:2023.

        Usage of this content is governed by Sonar’s terms and conditions. Redistribution is prohibited.

        Rule 6.2.3 - The source code used to implement an entity shall appear only once

        [basic.def.odr] Undefined 6.6; NDR 4

        Category: Required

        Analysis: Decidable, System

        Amplification

        For the purposes of this rule, an entity is a variable, type, function, or template thereof.

        Note: multiple different specializations for the same primary template and multiple overloads for a function with the same name but with different signatures are different entities.

        This rule requires that the source code used to implement an entity shall appear only once within a project. If the entity is inline, it can be implemented within a header file [1]; it is permitted to include such a header file [1] in multiple translation units.

        Additionally, explicit specializations of templates shall either be implemented in the same file as the primary template, or in a file where one of the fully specialized arguments is defined.

        Note: an entity may have no implementation — for example, an incomplete type does not need a definition when it is used as a tag.

        Rationale

        Non-inline entities shall only be defined once in a program. Inline entities can be defined once for each translation unit, but the definitions shall be identical. This principle is known as the one-definition rule.

        Requiring that the source code for the definition of any entity appears only once reduces the risk of violating the one-definition rule and makes the code simpler.

        The declaration of a template’s explicit specialization must be visible when it matches the arguments of the template that is being instantiated, otherwise, an implicit specialization will be generated, violating the one-definition rule. Implementing an explicit specialization in the same file as the primary template or the argument for which it is specialized ensures that this constraint is satisfied.

        Example

        // file1.h
        inline int16_t i = 10;
        
        // file2.h
        inline int16_t i = 10;              // Non-compliant - two definitions of i
        

        The following example demonstrates inconsistent definitions of b:

        // file1.cpp
        int16_t b;                          // Non-compliant - ill-formed (see file2.cpp)
        
        // file2.cpp
        int32_t b;                          // Non-compliant - ill-formed (see file1.cpp)
        

        In the following example, the full template specialization within a different file results in a violation of the one-definition rule (which is not the case for the template specialization A< D >, as that is within the file that defines D):

        // a.h - #include guard omitted for brevity
        template< typename T >
        class A {};
        
        // b.h
        #include "a.h"
        
        A< int32_t > const a1 {};
        
        // c.h
        #include "a.h"
        
        template<>
        class A< int32_t > {};              // Non-compliant
        
        // d.h
        #include "a.h"
        
        class D {};
        
        template<>
        class A< D > {};                    // Compliant
        
        // main.cpp
        #include "b.h"
        #include "c.h"                      // ODR violation
        #include "d.h"
        A< D > const a2 {};                 // OK - requires inclusion of d.h
        

        In the following example, the partial template specialization within a different file results in a violation of the one-definition rule:

        // wrap.h
        template< typename V >
        struct wrap
        {
          V value;
        };
        
        // wrap_ptr.h
        #include "wrap.h"
        
        template< typename V >
        struct wrap< V * > {}               // Non-compliant - should be in wrap.h
        
        // w.cpp
        #include "wrap.h"                   // No specialization visible
        
        wrap< char * > a_wrap;              // ODR violation - see wp.cpp
        
        // wp.cpp
        #include "wrap_ptr.h"               // Specialization visible
        
        wrap< char * > b_wrap;              // ODR violation - see w.cpp
        

        Glossary

        [1] Header file

        A header file is considered to be any file that is included during preprocessing (for example via the #include directive), regardless of its name or suffix.

        Copyright The MISRA Consortium Limited © 2023

          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI

        © 2025 SonarSource Sàrl. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use