SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C

C static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C code

  • All rules 420
  • Vulnerability14
  • Bug111
  • Security Hotspot19
  • Code Smell276

  • Quick Fix 27
Filtered: 66 rules found
cwe
    Impact
      Clean code attribute
        1. Function-like macros should not be invoked without all of their arguments

           Bug
        2. Function exit paths should have appropriate return values

           Bug
        3. The number of arguments passed to a function should match the number of parameters

           Bug
        4. Non-empty statements should change control flow or have at least one side-effect

           Bug
        5. Bitwise operators should not be applied to signed operands

           Bug
        6. Limited dependence should be placed on operator precedence

           Code Smell
        7. Function pointers should not be converted to any other type

           Bug
        8. Variables should be initialized before use

           Bug
        9. Hard-coded secrets are security-sensitive

           Security Hotspot
        10. "sprintf" should not be used

           Security Hotspot
        11. Changing working directories without verifying the success is security-sensitive

           Security Hotspot
        12. Setting capabilities is security-sensitive

           Security Hotspot
        13. Accessing files should not introduce TOCTOU vulnerabilities

           Vulnerability
        14. Account validity should be verified when authenticating users with PAM

           Vulnerability
        15. Using "tmpnam", "tmpnam_s" or "tmpnam_r" is security-sensitive

           Security Hotspot
        16. Using "strncpy" or "wcsncpy" is security-sensitive

           Security Hotspot
        17. Using "strncat" or "wcsncat" is security-sensitive

           Security Hotspot
        18. Using "strcat" or "wcscat" is security-sensitive

           Security Hotspot
        19. Using "strlen" or "wcslen" is security-sensitive

           Security Hotspot
        20. Changing directories improperly when using "chroot" is security-sensitive

           Security Hotspot
        21. Using "strcpy" or "wcscpy" is security-sensitive

           Security Hotspot
        22. "memset" should not be used to delete sensitive data

           Vulnerability
        23. POSIX functions should not be called with arguments that trigger buffer overflows

           Vulnerability
        24. Relational and subtraction operators should not be used with pointers to different arrays

           Bug
        25. Cipher algorithms should be robust

           Vulnerability
        26. Encryption algorithms should be used with secure mode and padding scheme

           Vulnerability
        27. Server hostnames should be verified during SSL/TLS connections

           Vulnerability
        28. "pthread_mutex_t" should not be locked when already locked, or unlocked when already unlocked

           Bug
        29. Using publicly writable directories is security-sensitive

           Security Hotspot
        30. Using clear-text protocols is security-sensitive

           Security Hotspot
        31. Blocking functions should not be called inside critical sections

           Code Smell
        32. Dereferenced null pointers should not be bound to references

           Code Smell
        33. Expanding archive files without controlling resource consumption is security-sensitive

           Security Hotspot
        34. Server certificates should be verified during SSL/TLS connections

           Vulnerability
        35. Using weak hashing algorithms is security-sensitive

           Security Hotspot
        36. Cryptographic keys should be robust

           Vulnerability
        37. Weak SSL/TLS protocols should not be used

           Vulnerability
        38. Dynamically allocated memory should be released

           Bug
        39. Freed memory should not be used

           Bug
        40. Memory locations should not be released more than once

           Bug
        41. Memory access should be explicitly bounded to prevent buffer overflows

           Bug
        42. Zero should not be a possible denominator

           Bug
        43. "sizeof" should not be called on pointers

           Bug
        44. XML parsers should not be vulnerable to XXE attacks

           Vulnerability
        45. Multiline blocks should be enclosed in curly braces

           Code Smell
        46. "nonnull" parameters and return values of "returns_nonnull" functions should not be null

           Bug
        47. Setting loose POSIX file permissions is security-sensitive

           Security Hotspot
        48. Conditionally executed code should be reachable

           Bug
        49. Null pointers should not be dereferenced

           Bug
        50. Using pseudorandom number generators (PRNGs) is security-sensitive

           Security Hotspot
        51. Resources should be closed

           Bug
        52. Hard-coded passwords are security-sensitive

           Security Hotspot
        53. Code annotated as deprecated should not be used

           Code Smell
        54. Unused assignments should be removed

           Code Smell
        55. All code should be reachable

           Bug
        56. "switch" statements should have "default" clauses

           Code Smell
        57. Switch cases should end with an unconditional "break" statement

           Code Smell
        58. Track uses of "TODO" tags

           Code Smell
        59. Track uses of "FIXME" tags

           Code Smell
        60. Assignments should not be made from within conditions

           Code Smell
        61. Insecure functions should not be used

           Vulnerability
        62. "scanf()" and "fscanf()" format strings should specify a field width for the "%s" string placeholder

           Vulnerability
        63. The value of an object must not be read before it has been set

           Bug
        64. Subtraction between pointers shall only be applied to pointers that address elements of the same array

           Bug
        65. A value should not be "unnecessarily written" to a local object

           Code Smell
        66. A function shall not contain "unreachable" statements

           Bug

        "nonnull" parameters and return values of "returns_nonnull" functions should not be null

        intentionality - logical
        reliability
        Bug
        • cwe
        • symbolic-execution
        • cert

        Pointers marked as "nonnull" may not be set to null, since they are typically not null-checked before use.

        Why is this an issue?

        How can I fix it?

        More Info

        A function’s return value and parameters may be decorated with attributes to convey additional information to the compiler and/or other developers.

        A commonly used attribute is nonnull which can be used to mark a function’s return value and parameters as shown in the following:

        #include <stdlib.h>
        #include <stdio.h>
        #include <string.h>
        
        __attribute__((returns_nonnull)) int *
        make_array_copy(int *src, size_t len) __attribute__((nonnull(1)));
        
        int *make_array_copy(int *src, size_t len) {
          int *dst = (int *)malloc(len * sizeof(int));
          if (dst == NULL) {
            perror("malloc failed");
            exit(1);
          }
          memcpy(dst, src, len);
          return dst;
        }
        

        The nonnull attribute is meant for other developers and as a hint for compilers. Values marked as nonnull are assumed to have non-null values.

        However, developers may accidentally break the nonnull attribute as shown in the following code snippet:

        __attribute__((returns_nonnull))
        int *foo(__attribute__((nonnull)) int *x) {
          x = 0; // This is compliant but might be surprising, use with caution
          foo(0); // Noncompliant: null is passed as an argument marked as "nonnull"
          return 0; // Noncompliant: return value is marked "nonnull" but null is returned
        }
        

        Failing to adhere to the attribute may introduce serious program errors. In particular, the compiler does not enforce that values marked as nonnull are indeed non-null at runtime; it is the developers' responsibility to adhere to the attribute. These values are typically not null-checked before use. Passing null (i.e., NULL, 0 or nullptr) as an argument to a parameter that is marked as nonnull or returning null from a function marked as returns_nonnull is, hence, likely to cause a null-pointer dereference. Compilers may even apply optimizations based on this attribute and might, for instance, remove an explicit null-check if the parameter is declared as nonnull — even in code outside of the function with the attribute.

        Note that the nonnull attribute is a GNU extension (see nonnull and returns_nonnull) which many compiler vendors have implemented.

        Note that it is allowed to assign null to a parameter marked as nonnull. This attribute is only concerned with the function call contract and does not control the evolution of the parameter variable. For example, a linked-list search could be implemented as follows:

        struct List {
          int value;
          List *next; // nullptr for a tail node.
        };
        
        
        List *findElement(List *l, int elem) __attribute__((nonnull(1)));
        
        List *findElement(List *l, int elem) {
          while(l && l->value != elem)
            l = l->next;
          return l;
        }
        

        What is the potential impact?

        In case a program dereferences a null pointer, it’s behavior is undefined. For programs that exercise undefined behavior the compiler no longer needs to adhere to the language standard and the program has no meaning assigned to it.

        In practice, dereferencing a null pointer may lead to program crashes, or the application may appear to execute correctly while losing data or producing incorrect results.

        Besides affecting the application’s availability, null-pointer dereferences may lead to malicious code execution, in rare circumstances. If null is equivalent to the 0x0 memory address that can be accessed by privileged code, writing, and reading memory is possible, which compromises the integrity and confidentiality of the application.

        Because compilers may apply optimizations based on the nonnull attribute, not respecting nonnull can also introduce more complex bugs such as resource leaks or infinite recursion as indicated in the following code snippet:

        struct List {
          int value;
          List *next; // nullptr for a tail node.
        };
        
        size_t len(List *n) __attribute__((nonnull));
        size_t len(List *l) {
          if (!l) return 0; // Impossible branch according to the attribute
          return 1 + len(l->next);
        }
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2025 SonarSource Sàrl. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use