SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C

C static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C code

  • All rules 315
  • Vulnerability13
  • Bug76
  • Security Hotspot19
  • Code Smell207

  • Quick Fix 19
Filtered: 59 rules found
cwe
    Impact
      Clean code attribute
        1. Function-like macros should not be invoked without all of their arguments

           Bug
        2. Function exit paths should have appropriate return values

           Bug
        3. The number of arguments passed to a function should match the number of parameters

           Bug
        4. Non-empty statements should change control flow or have at least one side-effect

           Bug
        5. Bitwise operators should not be applied to signed operands

           Bug
        6. Limited dependence should be placed on operator precedence

           Code Smell
        7. Variables should be initialized before use

           Bug
        8. Hard-coded secrets are security-sensitive

           Security Hotspot
        9. "sprintf" should not be used

           Security Hotspot
        10. Changing working directories without verifying the success is security-sensitive

           Security Hotspot
        11. Setting capabilities is security-sensitive

           Security Hotspot
        12. Accessing files should not introduce TOCTOU vulnerabilities

           Vulnerability
        13. Account validity should be verified when authenticating users with PAM

           Vulnerability
        14. Using "tmpnam", "tmpnam_s" or "tmpnam_r" is security-sensitive

           Security Hotspot
        15. Using "strncpy" or "wcsncpy" is security-sensitive

           Security Hotspot
        16. Using "strncat" or "wcsncat" is security-sensitive

           Security Hotspot
        17. Using "strcat" or "wcscat" is security-sensitive

           Security Hotspot
        18. Using "strlen" or "wcslen" is security-sensitive

           Security Hotspot
        19. Changing directories improperly when using "chroot" is security-sensitive

           Security Hotspot
        20. Using "strcpy" or "wcscpy" is security-sensitive

           Security Hotspot
        21. "memset" should not be used to delete sensitive data

           Vulnerability
        22. POSIX functions should not be called with arguments that trigger buffer overflows

           Vulnerability
        23. Cipher algorithms should be robust

           Vulnerability
        24. Encryption algorithms should be used with secure mode and padding scheme

           Vulnerability
        25. Server hostnames should be verified during SSL/TLS connections

           Vulnerability
        26. "pthread_mutex_t" should not be locked when already locked, or unlocked when already unlocked

           Bug
        27. Using publicly writable directories is security-sensitive

           Security Hotspot
        28. Using clear-text protocols is security-sensitive

           Security Hotspot
        29. Blocking functions should not be called inside critical sections

           Code Smell
        30. Expanding archive files without controlling resource consumption is security-sensitive

           Security Hotspot
        31. Server certificates should be verified during SSL/TLS connections

           Vulnerability
        32. Using weak hashing algorithms is security-sensitive

           Security Hotspot
        33. Cryptographic keys should be robust

           Vulnerability
        34. Weak SSL/TLS protocols should not be used

           Vulnerability
        35. Dynamically allocated memory should be released

           Bug
        36. Freed memory should not be used

           Bug
        37. Memory locations should not be released more than once

           Bug
        38. Memory access should be explicitly bounded to prevent buffer overflows

           Bug
        39. Zero should not be a possible denominator

           Bug
        40. "sizeof" should not be called on pointers

           Bug
        41. XML parsers should not be vulnerable to XXE attacks

           Vulnerability
        42. Multiline blocks should be enclosed in curly braces

           Code Smell
        43. "nonnull" parameters and return values of "returns_nonnull" functions should not be null

           Bug
        44. Setting loose POSIX file permissions is security-sensitive

           Security Hotspot
        45. Conditionally executed code should be reachable

           Bug
        46. Null pointers should not be dereferenced

           Bug
        47. Using pseudorandom number generators (PRNGs) is security-sensitive

           Security Hotspot
        48. Resources should be closed

           Bug
        49. Hard-coded passwords are security-sensitive

           Security Hotspot
        50. Code annotated as deprecated should not be used

           Code Smell
        51. Unused assignments should be removed

           Code Smell
        52. All code should be reachable

           Bug
        53. "switch" statements should have "default" clauses

           Code Smell
        54. Switch cases should end with an unconditional "break" statement

           Code Smell
        55. Track uses of "TODO" tags

           Code Smell
        56. Track uses of "FIXME" tags

           Code Smell
        57. Assignments should not be made from within conditions

           Code Smell
        58. Insecure functions should not be used

           Vulnerability
        59. "scanf()" and "fscanf()" format strings should specify a field width for the "%s" string placeholder

           Vulnerability

        Using pseudorandom number generators (PRNGs) is security-sensitive

        responsibility - trustworthy
        security
        Security Hotspot
        • cwe
        • cert

        PRNGs are algorithms that produce sequences of numbers that only approximate true randomness. While they are suitable for applications like simulations or modeling, they are not appropriate for security-sensitive contexts because their outputs can be predictable if the internal state is known.

        In contrast, cryptographically secure pseudorandom number generators (CSPRNGs) are designed to be secure against prediction attacks. CSPRNGs use cryptographic algorithms to ensure that the generated sequences are not only random but also unpredictable, even if part of the sequence or the internal state becomes known. This unpredictability is crucial for security-related tasks such as generating encryption keys, tokens, or any other values that must remain confidential and resistant to guessing attacks.

        For example, the use of non-cryptographic PRNGs has led to vulnerabilities such as:

        • CVE-2013-6386
        • CVE-2006-3419
        • CVE-2008-4102

        When software generates predictable values in a context requiring unpredictability, it may be possible for an attacker to guess the next value that will be generated, and use this guess to impersonate another user or access sensitive information. Therefore, it is critical to use CSPRNGs in any security-sensitive application to ensure the robustness and security of the system.

        Ask Yourself Whether

        • the code using the generated value requires it to be unpredictable. It is the case for all encryption mechanisms or when a secret value, such as a password, is hashed.
        • the function you use is a non-cryptographic PRNG.
        • the generated value is used multiple times.
        • an attacker can access the generated value.

        There is a risk if you answered yes to any of those questions.

        Recommended Secure Coding Practices

        • Use functions which rely on a cryptographically secure pseudorandom number generator (CSPRNG) such as randombytes_uniform() or randombytes_buf() from libsodium, or randomize() from Botan.
        • Use the generated random values only once.
        • You should not expose the generated random value. If you have to store it, make sure that the database or file is secure.

        Sensitive Code Example

        #include <random>
        // ...
        
        void f() {
          int random_int = std::rand(); // Sensitive
        }
        

        Compliant Solution

        #include <sodium.h>
        #include <botan/system_rng.h>
        // ...
        
        void f() {
          char random_chars[10];
          randombytes_buf(random_chars, 10);
          uint32_t random_int = randombytes_uniform(10);
        
          uint8_t random_chars[10];
          Botan::System_RNG system;
          system.randomize(random_chars, 10);
        }
        

        See

        • OWASP - Secure Random Number Generation Cheat Sheet
        • OWASP - Top 10 2021 Category A2 - Cryptographic Failures
        • OWASP - Top 10 2017 Category A3 - Sensitive Data Exposure
        • CWE - CWE-338 - Use of Cryptographically Weak Pseudo-Random Number Generator (PRNG)
        • CWE - CWE-330 - Use of Insufficiently Random Values
        • CWE - CWE-326 - Inadequate Encryption Strength
        • CWE - CWE-1241 - Use of Predictable Algorithm in Random Number Generator
        • CERT, MSC30-C. - Do not use the rand() function for generating pseudorandom numbers
        • CERT, MSC50-CPP. - Do not use std::rand() for generating pseudorandom numbers
        • Derived from FindSecBugs rule Predictable Pseudo Random Number Generator
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use