SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
C

C static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your C code

  • All rules 420
  • Vulnerability14
  • Bug111
  • Security Hotspot19
  • Code Smell276

  • Quick Fix 27
Filtered: 39 rules found
confusing
    Impact
      Clean code attribute
        1. #include directives in a file should only be preceded by other preprocessor directives or comments

           Code Smell
        2. Loops should not have more than one "break" or "goto" statement

           Code Smell
        3. Switch labels should not be nested inside non-switch blocks

           Code Smell
        4. Appropriate char types should be used for character and integer values

           Code Smell
        5. The first element of an array should not be accessed implicitly

           Code Smell
        6. Multicharacter literals should not be used

           Code Smell
        7. GNU attributes should be used correctly

           Code Smell
        8. Functions which do not return should be declared as "noreturn"

           Code Smell
        9. Functions with "noreturn" attribute should not return

           Bug
        10. "else" statements should be clearly matched with an "if"

           Code Smell
        11. A conditionally executed single line should be denoted by indentation

           Code Smell
        12. Macros should not be redefined

           Code Smell
        13. "#include_next" should not be used

           Code Smell
        14. String literals should not be concatenated implicitly

           Code Smell
        15. Types and variables should be declared in separate statements

           Code Smell
        16. Format strings should be used correctly

           Code Smell
        17. Conditional operators should not be nested

           Code Smell
        18. Increment should not be used to set boolean variables to 'true'

           Code Smell
        19. Loops with at most one iteration should be refactored

           Bug
        20. Deprecated K&R syntax should not be used for function definition

           Code Smell
        21. Redundant pairs of parentheses should be removed

           Code Smell
        22. "/*" and "//" should not be used within comments

           Code Smell
        23. "Global variables" shall not be used

           Code Smell
        24. The built-in unary "+" operator should not be used

           Code Smell
        25. The argument to a "mixed-use macro parameter" shall not be subject to further expansion

           Code Smell
        26. Local variables shall not have static storage duration

           Code Smell
        27. A function with non-"void" return type shall return a value on all paths

           Bug
        28. The parameters in all "declarations" or overrides of a function shall either be unnamed or have identical names

           Code Smell
        29. The comma operator should not be used

           Code Smell
        30. Parentheses should be used to make the meaning of an expression appropriately explicit

           Code Smell
        31. The same type aliases shall be used in all "declarations" of the same "entity"

           Code Smell
        32. Block scope "declarations" shall not be "visually ambiguous"

           Code Smell
        33. All identifiers used in the controlling expression of "#if" or "#elif" preprocessing directives shall be defined prior to evaluation

           Bug
        34. Parentheses shall be used to ensure macro arguments are expanded appropriately

           Code Smell
        35. "#undef" should only be used for macros defined previously in the same file

           Code Smell
        36. "#include" directives should only be preceded by preprocessor directives or comments

           Code Smell
        37. A variable declared in an "inner scope" shall not hide a variable declared in an "outer scope"

           Code Smell
        38. The character sequence "/*" shall not be used within a C-style comment

           Code Smell
        39. Controlling expressions should not be invariant

           Bug

        "#undef" should only be used for macros defined previously in the same file

        intentionality - clear
        maintainability
        Code Smell
        • confusing
        • misra-c++2023
        • misra-advisory

        Why is this an issue?

        More Info

        This rule is part of MISRA C++:2023.

        Usage of this content is governed by Sonar’s terms and conditions. Redistribution is prohibited.

        Rule 19.0.4 - #undef should only be used for macros defined previously in the same file

        [cpp.predefined] Undefined 4

        Category: Advisory

        Analysis: Decidable,Single Translation Unit

        Rationale

        Since macros are not subject to the usual scoping rules of the language, complex use of #undef can lead to confusion with respect to the existence or meaning of a macro when it is used in the code. However, it might be desirable to limit the number of active macros at any point in the code to help prevent inappropriate use; if a macro is only required for a specific purpose, a common idiom is to #define it, use it and #undef it immediately afterwards.

        Permitting #undef to be used for macros that are defined in the same file enables the scope of those macros to be restricted whilst preventing complex uses that could lead to confusion.

        Note: undefining a macro defined by the C++ Standard Library can result in undefined behaviour.

        Example

        // File.cpp
        
        #include "A.h"       // This header defines the macro M
        #undef M             // Non-compliant - defined in another file
        
        #define ID( name ) constexpr auto name = #name
        
        ID( IdA );
        ID( IdB );
        
        #undef ID            // Compliant - defined in this file
        

        Copyright The MISRA Consortium Limited © 2023

          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI

        © 2025 SonarSource Sàrl. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use