SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
Apex

Apex static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your APEX code

  • All rules 56
  • Vulnerability1
  • Bug12
  • Security Hotspot3
  • Code Smell40
Filtered: 6 rules found
suspicious
    Impact
      Clean code attribute
        1. Methods should not have identical implementations

           Code Smell
        2. Track parsing failures

           Code Smell
        3. Two branches in a conditional structure should not have exactly the same implementation

           Code Smell
        4. Identical expressions should not be used on both sides of a binary operator

           Bug
        5. Methods should not be empty

           Code Smell
        6. Nested blocks of code should not be left empty

           Code Smell

        Two branches in a conditional structure should not have exactly the same implementation

        adaptability - distinct
        maintainability
        Code Smell
        • design
        • suspicious

        Why is this an issue?

        More Info

        When the same code is duplicated in two or more separate branches of a conditional, it can make the code harder to understand, maintain, and can potentially introduce bugs if one instance of the code is changed but others are not.

        Having two whens in a switch statement or two branches in an if chain with the same implementation is at best duplicate code, and at worst a coding error.

        if (a >= 0 && a < 10) {
          doFirstThing();
          doTheThing();
        }
        else if (a >= 10 && a < 20) {
          doTheOtherThing();
        }
        else if (a >= 20 && a < 50) {
          doFirstThing();
          doTheThing();  // Noncompliant; duplicates first condition
        }
        else {
          doTheRest();
        }
        
        switch on i {
          when 1 {
            doFirstThing();
            doSomething();
          }
          when 2 {
            doSomethingDifferent();
          }
          when 3 {  // Noncompliant; duplicates when 1's implementation
            doFirstThing();
            doSomething();
          }
          when else {
            doTheRest();
          }
        }
        

        If the same logic is truly needed for both instances, then:

        • in an if chain they should be combined
        if ((a >= 0 && a < 10) || (a >= 20 && a < 50)) {
          doFirstThing();
          doTheThing();
        }
        else if (a >= 10 && a < 20) {
          doTheOtherThing();
        }
        else {
          doTheRest();
        }
        
        • for a switch, the values should be put in the when values list.
        switch on i {
          when 1, 3 {
            doFirstThing();
            doSomething();
          }
          when 2 {
            doSomethingDifferent();
          }
          when else {
            doTheRest();
          }
        }
        

        Exceptions

        Blocks in an if chain that contain a single line of code are ignored, as are blocks in a switch statement that contain a single line of code with or without a following break.

        if(a == 1) {
          doSomething();  //no issue, usually this is done on purpose to increase the readability
        } else if (a == 2) {
          doSomethingElse();
        } else {
          doSomething();
        }
        

        But this exception does not apply to if chains without else-s, or to switch-es without default clauses when all branches have the same single line of code. In the case of if chains with else-s, or of switch-es with default clauses, rule S3923 raises a bug.

        if(a == 1) {
          doSomething();  //Noncompliant, this might have been done on purpose but probably not
        } else if (a == 2) {
          doSomething();
        }
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Enterprise
          Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use