Using the same value on both sides of a binary operator is a code defect. In the case of logical operators, it is either a copy/paste error and,
therefore, a bug, or it is simply duplicated code and should be simplified. In the case of bitwise operators and most binary mathematical operators,
having the same value on both sides of an operator yields predictable results and should be simplified as well.
Noncompliant code example
if ( a == a ) { // always true
foo();
}
if ( a != a ) { // always false
foo();
}
if ( a == b && a == b ) { // if the first one is true, the second one is too
foo();
}
if ( a != b || a <> b ) { // if the first one is true, the second one is too
foo();
}
Integer i = 5 / 5; // always 1
Integer j = 5 - 5; // always 0
Exceptions
- This rule ignores
*, +, ^, &, |, =, <<,
>> and >>>.
