SonarSource Rules
  • Products

    In-IDE

    Code Quality and Security in your IDE with SonarQube Ide

    IDE extension that lets you fix coding issues before they exist!

    Discover SonarQube for IDE

    SaaS

    Code Quality and Security in the cloud with SonarQube Cloud

    Setup is effortless and analysis is automatic for most languages

    Discover SonarQube Cloud

    Self-Hosted

    Code Quality and Security Self-Hosted with SonarQube Server

    Fast, accurate analysis; enterprise scalability

    Discover SonarQube Server
  • SecretsSecrets
  • ABAPABAP
  • AnsibleAnsible
  • ApexApex
  • AzureResourceManagerAzureResourceManager
  • CC
  • C#C#
  • C++C++
  • CloudFormationCloudFormation
  • COBOLCOBOL
  • CSSCSS
  • DartDart
  • DockerDocker
  • FlexFlex
  • GitHub ActionsGitHub Actions
  • GoGo
  • HTMLHTML
  • JavaJava
  • JavaScriptJavaScript
  • JSONJSON
  • JCLJCL
  • KotlinKotlin
  • KubernetesKubernetes
  • Objective CObjective C
  • PHPPHP
  • PL/IPL/I
  • PL/SQLPL/SQL
  • PythonPython
  • RPGRPG
  • RubyRuby
  • RustRust
  • ScalaScala
  • ShellShell
  • SwiftSwift
  • TerraformTerraform
  • TextText
  • TypeScriptTypeScript
  • T-SQLT-SQL
  • VB.NETVB.NET
  • VB6VB6
  • XMLXML
  • YAMLYAML
ABAP

ABAP static code analysis

Unique rules to find Bugs, Vulnerabilities, Security Hotspots, and Code Smells in your ABAP code

  • All rules 94
  • Vulnerability4
  • Bug14
  • Security Hotspot7
  • Code Smell69
Filtered: 4 rules found
suspicious
    Impact
      Clean code attribute
        1. Two branches in a conditional structure should not have exactly the same implementation

           Code Smell
        2. Identical expressions should not be used on both sides of a binary operator

           Bug
        3. "NOT IN" should not be used

           Code Smell
        4. Nested blocks of code should not be left empty

           Code Smell

        Two branches in a conditional structure should not have exactly the same implementation

        adaptability - distinct
        maintainability
        Code Smell
        • design
        • suspicious

        Why is this an issue?

        More Info

        When the same code is duplicated in two or more separate branches of a conditional, it can make the code harder to understand, maintain, and can potentially introduce bugs if one instance of the code is changed but others are not.

        Having two WHEN in a CASE statement or two branches in an IF chain with the same implementation is at best duplicate code, and at worst a coding error.

        IF a >= 0 AND a < 10.
          doFirst.
          doTheThing.
        ELSEIF a >= 10 AND a < 20.
          doTheOtherThing.
        ELSEIF a >= 20 AND a < 50.
          doFirst.       // Noncompliant; duplicates first condition
          doTheThing.
        ENDIF.
        
        CASE i.
          WHEN 1.
            doFirst.
            doSomething.
          WHEN 2.
            doSomethingDifferent.
          WHEN 3.  // Noncompliant; duplicates case 1's implementation
            doFirst.
            doSomething.
          WHEN OTHERS.
            doTheRest.
        ENDCASE.
        

        If the same logic is needed for both instances the conditions should be combined.

        IF (a >= 0 AND a < 10) OR (a >= 20 AND a < 50).
          doFirst.
          doTheThing.
        ELSEIF a >= 10 AND a < 20.
          doTheOtherThing.
        ENDIF.
        
        CASE i.
          WHEN 1 OR 3.
            doFirst.
            doSomething.
          WHEN 2.
            doSomethingDifferent.
          WHEN OTHERS.
            doTheRest.
        ENDCASE.
        

        Exceptions

        Blocks in an IF chain or in CASE statement that contain a single line of code are ignored.

        IF a >= 0 AND a < 10.
          doTheThing.
        ELSEIF a >= 10 AND a < 20.
          doTheOtherThing.
        ELSEIF a >= 20 AND a < 50.
          doTheThing.  // no issue, usually this is done on purpose to increase the readability
        ENDIF.
        

        But this exception does not apply to IF chains without final ELSE-s, or to CASE-s without WHEN OTHERS clauses when all branches have the same single line of code. In case of IF chains with ELSE-s, or of CASE-s with WHEN OTHERS clauses, rule S3923 raises a bug.

        IF a >= 0 AND a < 10. //Noncompliant, this might have been done on purpose but probably not
          doTheThing.
        ELSEIF a >= 10 AND a < 20.
          doTheThing.
        ENDIF.
        
          Available In:
        • SonarQube IdeCatch issues on the fly,
          in your IDE
        • SonarQube CloudDetect issues in your GitHub, Azure DevOps Services, Bitbucket Cloud, GitLab repositories
        • SonarQube ServerAnalyze code in your
          on-premise CI
          Developer Edition
          Available Since
          9.1

        © 2008-2025 SonarSource SA. All rights reserved.

        Privacy Policy | Cookie Policy | Terms of Use